Giter Club home page Giter Club logo

Comments (3)

csswizardry avatar csswizardry commented on May 30, 2024

Hi,

I see the problem in the initial fiddle, however I believe the ‘solutions’ are less desirable than the initial issue…

The issue seems to be—and forgive me if I’m wrong—that the links don’t quite fill the whole nav, but the solutions all have much more questionable problems of their own (in my opinion).

You raise a valid point, but I think we need to look for a better fix :)

Cheers,
H

from inuit.css.

pintomau avatar pintomau commented on May 30, 2024

There's that issue, but more importantly and noticeable, the elements aren't evenly distributed/spaced, due to the table behaviour. You could manually adjust, but then it defeats it's purpose in my mind.

Also, you can't use absolutely positioned pseudo elements with nav--fit in Firefox (thinking about subnavs, etc). Firefox doesn't have position:relative behaviour for table cells. This is a big one for me.

Sure thing, just sharing the love. I know how it isn't 'THE solution' as it is hackey, but has worked for me in instances where nav--fit wouldn't, without much hassle.

from inuit.css.

Hainesy avatar Hainesy commented on May 30, 2024

Okay I've just come across this issue of a gap on the right-hand side in chrome.

Here's the code:

.primary-nav {
    @extend .nav, .nav--block, .nav--fit, .nav--banner;
    .primary-nav__item a {
        background-color: #cceeee;
    }
}
<nav>
    <ul class="primary-nav">
        <li class="primary-nav__item"><a href="#" class="push-half--right">Menu Item 1</a></li>
        <li class="primary-nav__item"><a href="#" class="push-half--right">Menu Item 2</a></li>
        <li class="primary-nav__item"><a href="#" class="push-half--right">Menu Item 3</a></li>
        <li class="primary-nav__item"><a href="#">Menu Item 4</a></li>
    </ul>
</nav>

It fits perfectly in Firefox, but in chrome (27) it's very undesirable. It's the same regardless of the "push-half--right" classes on the link tags.

image

Is there any progress on getting this resolved?

from inuit.css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.