Giter Club home page Giter Club logo

Comments (8)

kof avatar kof commented on June 7, 2024 1

@iamstarkov is working on a ThemeProvider which will work with styled-jss and react-jss and many others.

from styled-jss.

igl avatar igl commented on June 7, 2024

jss-theme-reactor? the next version of material-ui will be using it.

from styled-jss.

kof avatar kof commented on June 7, 2024

jss-theme-reactor is more an internal tool for mui, for now its not stable enough to rely on it.

from styled-jss.

igl avatar igl commented on June 7, 2024

Unstable internal tool? It's mentioned high up on the JSS README

Making the ThemeProvider portable is already trivial. The rewiring to the component lib is a little annoying but easy peasy.

I just started to look at styled-jss and it's not looking so good there. I probably have to merge the context to the props in a hof/hoc. It should behave like styled-components/styletron imo.

ThemeProvider just needs to provide this:

ThemeProvider.contextTypes = {
    theme: PropTypes.object,
    styleManager: PropTypes.object,
}

styleManager just goes to the jss-lib and theme is read by the component directly:

styledComponent.button`
    color: ${ (props, context) => props.color || context.theme.color.main || 'blue' };
`

styletron('button', (props, context) => {
    color: props.color || context.theme.color.main || 'blue'
})

with hof:

styledComponent.button`
    color: ${ fromTheme('color.main', 'blue') };
`

styletron('button', (props, context) => {
    color: fromTheme('color.main', 'blue')
})

from styled-jss.

kof avatar kof commented on June 7, 2024

Yep, I probably added it too early.

from styled-jss.

kof avatar kof commented on June 7, 2024

The idea we work on is one ThemeProvider which will work with all libs, react-jss, styled-jss, styled-components etc etc

from styled-jss.

kof avatar kof commented on June 7, 2024

We are just not there yet, we still need to finalize it.

from styled-jss.

kof avatar kof commented on June 7, 2024

tbc in #20

from styled-jss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.