Giter Club home page Giter Club logo

Comments (4)

stakach avatar stakach commented on August 26, 2024 1

sweet that is fixed in the v2.1.4 release

from jwt.

stakach avatar stakach commented on August 26, 2024

Sorry, I didn't realise issues were disabled
is it possible that the process is exiting before GC cleans up the objects?

GC seems to only clean up objects once the scope they were created in has disappeared
crystal-lang/crystal#10469

from jwt.

marzhaev avatar marzhaev commented on August 26, 2024

The issue was discovered in production and replicated in different ways. I don't believe it has got to do with crystal-lang/crystal#10469.

My fix for Crystal MongoDB driver could be found here. Scroll down to the very bottom to collection.cr. It may be tough to read the code, let me explain.

C binding inits 'reply' which is a C type and hence does not get GC-ed by Crystal automatically. If it were inside a Crystal type then we should have used Crystal's finalized to manually free memory.

The same may be happening with openssl_ext. Around line 20 we may be bypassing Crystal's GC and not freeing bio manually via LibCrypto.bio_free further down the code. Unfortunately, I have never been able to get acquainted with OpenSSL's API to dig further.

from jwt.

stakach avatar stakach commented on August 26, 2024

Great point!
I can't imagine many people are too intimately acquainted with OpenSSL's API - I'll have a dig

from jwt.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.