Giter Club home page Giter Club logo

Comments (8)

andrewazores avatar andrewazores commented on June 24, 2024 1

(it's frustrating that GitHub Packages still doesn't allow unauthenticated downloads)

from cryostat-agent.

ebaron avatar ebaron commented on June 24, 2024

This is the pull_request_target issue right?

from cryostat-agent.

andrewazores avatar andrewazores commented on June 24, 2024

I think so, yes. The secret is probably unreadable to the actions runners with the current configuration so the authentication fails because the password/token being provided in the Maven settings.xml would be an empty string.

from cryostat-agent.

andrewazores avatar andrewazores commented on June 24, 2024

#149 (comment)

from cryostat-agent.

andrewazores avatar andrewazores commented on June 24, 2024

It looks like the CI job also needs to (re)trigger when PRs are labelled or unlabelled:

#150

This PR is failing because the runner thinks safe-to-test is missing, but it is actually there, and removing/re-adding the label doesn't trigger the job again, nor does it seem to be able to refresh its state on a re-run.

pull_request_target:

vs

https://github.com/cryostatio/cryostat/blob/main/.github/workflows/pr-ci.yml#L13

from cryostat-agent.

maxcao13 avatar maxcao13 commented on June 24, 2024

Sounds good, I'll redo it today.

from cryostat-agent.

maxcao13 avatar maxcao13 commented on June 24, 2024

Fixed with #151, hopefully.

from cryostat-agent.

andrewazores avatar andrewazores commented on June 24, 2024

Looks good:
https://github.com/cryostatio/cryostat-agent/actions/runs/5292782560/jobs/9580084638?pr=150

from cryostat-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.