Sass doesn't apply to themes' css/ directory about cryogen-core HOT 5 CLOSED

Hmm I didn't think about this when I added the theming support... I think it would make sense to make the currently existing config keys accept multiple directories. A PR would be great!

from cryogen-core.

Getting into the thick of it, and I had a question. How much do you want to avoid breaking changes?

In particular, there's an undocumented effect of how sass is currently called. The configuration doc says you need to add the css directory to the :resources list, but the way sass is called, it works even if you forget to do that. Likewise, even though :sass-src is set to css by default, and the css directory doesn't exist by default, it doesn't currently produce an error. (For any other resource directory, not existing is an error.) Should I fix that, if people might be relying on it, or preserve that behavior?

Mostly, my aim is to separate compiling Sass files from copying them to the public directory, as they're currently combined in a way that makes it hard to add more dirs. The idea is to compile all Sass files first, then copy the resources over.

from cryogen-core.

I'd rather clear up all the inconsistencies than avoid breaking changes. If your approach feels intuitive then I'd say go for it.

Mostly, my aim is to separate compiling Sass files from copying them to the public directory, as they're currently combined in a way that makes it hard to add more dirs. The idea is to compile all Sass files first, then copy the resources over.

I think this will definitely clear up any confusion in the future.

from cryogen-core.

In that case, to preserve the current behavior, how about I leave the default :sass-src as css, but add a css directory to the main cryogen repo, so it works correctly by default. Plus, that'll show people where to place non-theme Sass/CSS anyway.

from cryogen-core.

Sounds good to me.

from cryogen-core.