Giter Club home page Giter Club logo

Comments (8)

yogthos avatar yogthos commented on June 12, 2024

just to double check, you're putting the files in resources/templates/css correct?

from cryogen-core.

ipavl avatar ipavl commented on June 12, 2024

Yes. I've also tried specifying other folders in the config file, but got the same result. Same with just renaming the given screen.css file to screen.scss.

from cryogen-core.

yogthos avatar yogthos commented on June 12, 2024

Hmm, yeah it looks like find-sass-files might be getting a wrong folder. It looks for files in the folder that it's passed in here. The folder that's passed in is whatever the sass-src key points to. That would be relative to project root.

I suspect it probably needs to be prefixed with resources/templates/. In the meantime, perhaps try setting :sass-src "resources/templates/css" and I suspect that should work.

from cryogen-core.

yogthos avatar yogthos commented on June 12, 2024

Ok, looks like the paths were the problem. I updated and tested locally, the template path and the output path should both get prefixed correctly now.

from cryogen-core.

ipavl avatar ipavl commented on June 12, 2024

That sounds probable; I'll verify your fix later. The regex looked fine, so an incorrect path sounds likely.

from cryogen-core.

lacarmen avatar lacarmen commented on June 12, 2024

I just pushed out a new version of cryogen-core to clojars so setting :sass-src "css" rather than :sass-src "resources/templates/css" should work now. Just update the dependency in your project.clj file.

from cryogen-core.

ipavl avatar ipavl commented on June 12, 2024

Basic compilation seems to work fine now. Thank you both.

There are some oddities, but they aren't really related to this exact issue:

  • the compiled .css file is kept in the :sass-src directory
  • the source .scss file is copied to the :sass-dest directory in public/, as well as a .map file
  • :sass-dest seems to be ignored, as setting :sass-src to "scss" and :sass-dest to "nil" will produce the .css file in "scss"
    • in this case, "scss" must be added to resources in config.edn for this to work at all, but if users only want to separate their source CSS files from their SASS ones (e.g. CSS in css and Sass in scss) and have a single "css" output (e.g. css), then this doesn't seem possible - I think this is as designed, but it might be something to reconsider

Sass also produces a .sass-cache directory, which should probably be added to .gitignore, but that might be better suited for the user's end (at least, Cryogen itself).

from cryogen-core.

yogthos avatar yogthos commented on June 12, 2024

I did notice the fact that the generated files don't get cleaned as well, but I guess that's a bit less of an issue. Perhaps it might make more sense to copy the sass files to the destination folder first and then compile them there.

from cryogen-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.