config based themes about cryogen-core HOT 8 CLOSED

Agree.

I have some thoughts on this topic.

Pull out hardcoded template variables into config as default config.

            (render-file "templates/html/layouts/page.html" ;should be read from config
                         (merge params
                                {:servlet-context "../"
                                 :page            page
                                 :uri             uri}))

Select themes by using config.

Add themes folder for containing themes

templates/html -> templates/themes/default/html
templates/css -> templates/themes/default/css
templates/js -> templates/themes/default/js

The resources will be copied first. After themes resources copying, templates/{css,js,404.html}.
will be copied and override the theme's same file name resources if any.

Lookup theme by the theme name in config

This line in config.edn

{:theme "blues"}

Fetch themes from github

Create a central repository for lookup theme

cryogen-project/cryogen-themes

Add leiningen plugin lein-cryogen-theme to template project

The plugin should provide following commands

Add leiningen template cryogen-theme for developing a new theme

lein new cryogen-theme freaky-cool

Is it good for implementing your idea like this?

from cryogen-core.

Yes, I think this is a good way to do it. I've merged your pr and made a few fixes for the config based theme stuff in 4511536.

The project structure has been changed slightly. I'll have to reflect that in the documentation.

I'm going to leave this issue open until I add some more themes

from cryogen-core.

great! we should add some documentation for migrating from 0.1.21 to 0.1.22.

from cryogen-core.

Would it be possible to somehow specify additional folders in a theme file? Because right now it seems that only 'css/', 'js/' and 'html/' folders are pulled in from a theme. The current use case is to include additional fonts and images, that can be specific to a theme.

from cryogen-core.

You can add your resources in the theme folder and then specify then in the :resources parameter inside config.edn. The compiler should copy them over to the output folder

from cryogen-core.

Slight update, if anyone's still reading. As of 0.1.57, themes can have their own config.edn file that gets merged with the main config, so they can specify additional directories for things like :resources.

from cryogen-core.

I've been with Cryogen since about 0.1.60 and always known the last comment to be true and have utilized it; and I see 0.1.22 and 0.1.57 as the latest versions mentioned. Is there reason for this ticket to be open?

from cryogen-core.

Is there reason for this ticket to be open?

I guess not. The themes are swappable via config right now, but they don't pull from Github -- all of them are included when you create a Cryogen project through Leiningen. I don't see that as a problem, so let's close this.

from cryogen-core.