Feature Request: Improve error formatting about gofalcon HOT 3 CLOSED

I haven't had the time to fully dive into how these files were being autogenerated and how to workaround this. Luckily you did :D Thanks for showing me how it's done!

Yes, I've failed to notice that the Code and Message fields were once again pointers. I've looked at your commit and I see you nicely worked around this. I've added two comments about unconventional spaces.

Thanks for your help and I'm looking forward to a new release with improved error formatting :D

from gofalcon.

Thanks @ShariJoosten, I released v0.2.9 with the fix for this.

from gofalcon.

Hello @ShariJoosten,

Thanks for the issue report!

Your analysis is very accurate and I like the solution you have proposed. I have created pr #116 for this.

What I have noticed, however, is that I cannot simply introduce:

func (m *MsaAPIError) String() string {
	return fmt.Sprintf("%+v", *m)
}

as that would end-up with outputs like:

&{Errors:[{Code:0xc0004605ac Message: 0xc000126360}]

(tested with go1.16.5).

So, I have introduced slightly more verbose methods to do the formatting.

Note: There is actually way to modify the behaviour of autogenerated code by introducing new files into the source directory. Only those files that are autogenerated are being re-generated periodically, the others are left untouched.

from gofalcon.