Comments (5)
dylan-bourque
commented on August 25, 2024
1
@wtrep I just tagged v0.18.0. Let me know if that doesn't work for you.
from csproto.
dylan-bourque
commented on August 25, 2024
@wtrep this was a miss on my part. I wrongly assumed that trying to unmarshal no data should be an error.
That snippet in the generated code should just return nil instead of an error and leave the message unmodified. Happy to review a PR if you want to submit one. If not, I'll fix this as soon as I finish up some other in-flight work I have.
The templates are here and you'd need to update both singlefile.go.tmpl and permessage.go.tmpl. Go text templates aren't great at sharing code. 😢
from csproto.
wtrep
commented on August 25, 2024
No problem ! I'll submit a PR
from csproto.
dylan-bourque
commented on August 25, 2024
@wtrep I had some spare bandwidth so I went ahead and knocked this out. This should resolve your issue.
from csproto.
wtrep
commented on August 25, 2024
Thanks @dylan-bourque !
from csproto.
Related Issues (20)
- codegen: generated code does not return an error when unmarshaling data and required fields are not present
- import package alias not generated by protoc-gen-fastmarshal HOT 17
- Rename Size() method HOT 2
- protoc-gen-fastmarshal doesn't support optional keyword of protobuf3 HOT 1
- EncodeNested with custom keys HOT 3
- Issue templates
- .Decode() indexing panic HOT 1
- .devcontainer for VSCode/CodeSpaces integration HOT 1
- Pull Request Template
- Add Codeql Security Scanning HOT 1
- Add Dependabot integration
- Empty messages generate bad syntax HOT 2
- float32 and double not supported? HOT 5
- Error when a proto2 required bytes field is set to a zero-length slice
- Incorrect data when round-tripping messages with fields set to empty strings
- generated code for "oneof double" is wrong HOT 1
- Handle WKTs in JSONMarshaler HOT 2
- Hide fields during marshal HOT 1
- Missing Equal method
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csproto.