Refactor fetch_all feature about crowdin-api-client-ruby HOT 10 CLOSED

@sabarish98 you're right, the optional limit and offset parameters could be missing in the request

Probably, it would be enough to check only the name of the method. I hope that all the list methods have the list_ part 🙂

from crowdin-api-client-ruby.

@andrii-bodnar : Yeah, probably, the method name alone should be enough. We can also check if all the methods that support pagination has the prefix.

I believe we can also raise the same error which is already being raised if an unsupported method is given.

I would love to work on this, but probably after doing the docs first

from crowdin-api-client-ruby.

@sabarish98 sure, thank you! So I'll assign this issue to you

from crowdin-api-client-ruby.

@andrii-bodnar : That's fine, I was just juggling a lot of stuff and this got pushed back. Open a PR for this now.

Please check #35 and let me know if anything needs to be changed

from crowdin-api-client-ruby.

This would be interesting to work on. All the method names beginning with list_ would support fetch_all feature? Or is there a further classification in the supported methods? @andrii-bodnar

from crowdin-api-client-ruby.

@sabarish98 we can rely on the list_ part of the method name, but the main characteristic of these methods is the ability to be paginated (presence of the limit and offset parameters)

from crowdin-api-client-ruby.

@andrii-bodnar : Yes, I understood the pagination aspect, but even if those optional params aren't supplied, we are setting a default value right?

Are you suggesting we use both the method name prefix as well as the presence of these optional params?

from crowdin-api-client-ruby.

@sabarish98 do you have any progress on this?
I am going to release a new version of the API client and just wondering if I can wait for this issue before the release

from crowdin-api-client-ruby.

Hey @andrii-bodnar, when's the plan to release it? I will let you know if this can be done before that or not

from crowdin-api-client-ruby.

@sabarish98 there's no plan with a strict deadline, but probably the next week would be good for release.

Anyway, I'm not forcing you to finish this issue 🙂
If you need more time for this then I will just release a new version and then another version will be released.

from crowdin-api-client-ruby.