Custom Fields content lost when moving to another Swimlane about metamagik HOT 7 CLOSED

Interesting. I'll take a look.

from metamagik.

@basti79
I was unable to reproduce, and to be honest, am not sure how it would even remotely be possible for the metadata to vanish by just moving to a swimlane. It just doesn't work that way. Metadata is stored in the taskmetadata table, and the relationship is the task id. Only way to break the chain would be for the task id to change.

I tried:
Moving task to different swimlane via the board
Moving task to different swimlane via "Move Position"
Moving task to a different project and different swimlane via "Move to different project"

The custom fields never vanished and remained intact.

Maybe provide some more details?

i.e.

• Confirm your plugin version
• What is your system configuration (found in settings>about)
• Confirm your kanboard version
• Exact steps to reproduce
• What other plugins are installed

from metamagik.

@creecros
Thanks for your work, first let me answer your questions:

• metaMagik 1.2.5
• Configuration: (actually this is a docker container):
  Application version: 1.2.9
  PHP version: 7.2.14
  PHP SAPI: fpm-fcgi
  OS version: Linux 4.18.0-2-amd64
  Database driver: sqlite
  Database version: 3.26.0
  Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36
• no other plugins

The actual news: By reproducing this problem I found out it's linked to an automatic action "Assign a color when the task is moved to a specific swimlane". Without this everything is ok, but when automatically changing the color when moving to a specific swimlane and then using the board to drag-and-drop the task the field contents are lost.

Greets
Sebastian.

from metamagik.

Ok, I reproduced it. Let me look into it.

from metamagik.

I have little understanding of Pimple...but it appears that the model override:

does not affect Actions. I'm guessing there is another container that needs that override, no clue as to how to call it, change it, etc...

I'll have to study. Maybe @fguillot might help answer this question for me?

However there is a work around. Make your own action, and use the NewTaskModificationModel supplied in the plugin.

from metamagik.

@basti79

After performing several tests, I figured out what is going on. The model is actually overriden, but I built the model with Modifcations from the TaskModification Form, not via an Action, so the $values do not contain the metadata to replace them. Hence, they disappear.

I should be able to fix this, stay tuned, it's getting late tonight, so maybe tomorrow.

from metamagik.

This should fix it:
https://github.com/creecros/MetaMagik/releases/tag/1.2.6

Please report back if you see any other issues.

from metamagik.