Support `GROUP BY ALL` about crate HOT 9 OPEN

Hi, Can i Work on this feature

from crate.

Referencing the columns by ordinal is an alternative - although a bit less convenient:

SELECT
  col1,
  agg(col2),
  col3
FROM t01;
GROUP BY
  1, 3;

from crate.

Referencing the columns by ordinal is an alternative - although a bit less convenient:

Which is even more error-prone when adjusting queries.
But overall this is more about convenience anyway.

from crate.

@DHRUV6029 Thx for volunteering to work on this!
Please let us know of any help you might need.

from crate.

Hello , Thanks for assigning me the task.
I had few queries @mfussenegger mentioned do we need ordinal number refrence or, we just want to support Group by ALL
clause

Thanks

from crate.

@DHRUV6029 Just GROUP BY ALL. Ordinal number references are already implemented.

from crate.

Hi can you guys help me with files where code for group by is already implemented ?
Thanks

from crate.

Hi can you guys help me with files where code for group by is already implemented ? Thanks

You'll have to extend the parser grammar to allow for ALL as an alternative to the list:

This then implies that the QuerySpecification structure has to change the representation of the GROUP BY:

Could model this via a GroupBy node, or maybe we can introduce a Either<L, R>.

The ALL case then needs to be resolved to the actual columns in:

from crate.

Thanks , Will submit a PR by this weekend

from crate.