Discussion: `/public/avatar` and `/:sharing-id/recipients/:index/avatar` about cozy-stack HOT 3 OPEN

Hi,

Issue

1. Using the convert binary force a external dependency to ImageMagick and this is a really big library.
2. The convert command need a write/read into the filesystem and so it require an access to the filesystem.

Yes, but we would still need ImageMagick without this feature. ImageMagick is used to generate thumbnails for uploaded images from the users, and it is quite good for being able to do that with weird formats.

Do not use those endpoints

We make the choice to add an endpoint and make the call to it from webapps, even if we have a component in cozy-ui for that. The reason is that the initials are just a placeholder. Later, we will want to allow users to choose their own avatar. But it is some works to pick a file, crop it, etc. and it has not been prioritized for the moment. Having the endpoint will make things smoother when we will implement that.

Use ajstarks/svgo

Looks good to me.

@Crash-- just to be sure, you don't see any issue by using SVG for the initial avatars?

from cozy-stack.

@Crash-- just to be sure, you don't see any issue by using SVG for the initial avatars?

I just checked on cozy-sharing, the lib just take the URL the stack returns and send it to Avatar (https://github.com/cozy/cozy-libs/blob/2896910f28d12e829f46b429ab25c1b84841a674/packages/cozy-sharing/src/components/Recipient.jsx#L144-L153) and Avatar is only doing an <img src={link} (https://github.com/cozy/cozy-ui/blob/master/react/Avatar/index.jsx#L68) so I think we're good on that.

Also, it seems that we're only adding background-color on the parent element, so I think we're good too on this path.

I don't see any issue by using SVG for initial avatars! Au contraire

from cozy-stack.

Yes, but we would still need ImageMagick without this feature. ImageMagick is used to generate thumbnails for uploaded images from the users, and it is quite good for being able to do that with weird formats.

I have hope to find a go lib for that but this is an another subject for later.

We make the choice to add an endpoint and make the call to it from webapps, even if we have a component in cozy-ui for that. The reason is that the initials are just a placeholder. Later, we will want to allow users to choose their own avatar. But it is some works to pick a file, crop it, etc. and it has not been prioritized for the moment. Having the endpoint will make things smoother when we will implement that.

This will be so cool!

I have done some tests in local and it seems to work but if you want I can put this change behind a feature flag in order to allow you to test internally. I only need an example of feature flag setup. What do you think of it?

from cozy-stack.