Giter Club home page Giter Club logo

Comments (3)

marvinsxtr avatar marvinsxtr commented on August 28, 2024

@KhaosT Thank you for your contribution! I looked into this and found some things to consider here.

If we only check the manifest.json, in theory everyone could generate any Apple Wallet pass. A modified trademark of the pass is prohibited by Apple and could lead to the revocation of my Apple Developer Certificate. See this excerpt from the Apple Developer Agreement.

To preserve the trademark, I suggest checking against the icon/logo hash on the server side. In order to preserve other static content of the pass, we would have to modify the structure of the pkpass file in some way, e.g by adding a json file of which we again check the hash on the server.

Another concern is that we do not verify the validity of the created vaccination certificate at the moment. This is something we would also have to do on the server and need the QR Code data for I believe. See this issue.

The best compromise would be to have the user opt in to validate the pass. In this case, the data would be sent to the server for validation and pass generation. If they opt out however, we would generate the pass in the browser and only check against the trademark and some static content if possible (e.g. a visible hint that the certificate may be invalid).

I am looking forward to your and the others ideas on this.

from covidpass.

marvinsxtr avatar marvinsxtr commented on August 28, 2024

To preserve the trademark, I suggest checking against the icon/logo hash on the server side.

I pushed it in this configuration now.

from covidpass.

hauketoenjes avatar hauketoenjes commented on August 28, 2024

Hi,

we transitioned the frontend to the new API written in C#.

The frontend generates the whole pass and only send the hashed pass.json to the server. This also includes the information about color because the icon hashes are different (either black or white icons).

from covidpass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.