Giter Club home page Giter Club logo

Comments (14)

nevinsm avatar nevinsm commented on September 27, 2024 18

FWIW My personal preference for how to handle this would be to archive and leave up the original repository with a note that it is deprecated and moved here. Start this one fresh with a commit that changes the names and then tag it as v2.0.0 to reflect the breaking change. You lose the old git history, but then the bifurcation is clean at least. If you want to keep the history, delete the old tags off of this repo.

from air.

xiantang avatar xiantang commented on September 27, 2024 4

image
should be fixed. I've tested in docker container.

PLS use go install github.com/air-verse/air@latest
I'll let this issue open, if u have any problem.

from air.

fadiinho avatar fadiinho commented on September 27, 2024 3

+1 seeing this as well

I just revert the PR, still have issue?

Yep, I'm still having the same error.
The error disappears if use go install github.com/air-verse/air@latest instead of go install github.com/cosmtrek/air@latest as in the documentation.

from air.

xiantang avatar xiantang commented on September 27, 2024 2

will be github.com/air-verse/air in the end.

from air.

jarielbalberona avatar jarielbalberona commented on September 27, 2024 1

I got this error. Any update?

from air.

xiantang avatar xiantang commented on September 27, 2024

I just release a new version, should be fixed

from air.

xiantang avatar xiantang commented on September 27, 2024

still have issue , so i revert the PR

from air.

raymondjacobson avatar raymondjacobson commented on September 27, 2024

+1 seeing this as well

from air.

xiantang avatar xiantang commented on September 27, 2024

+1 seeing this as well

I just revert the PR, still have issue?

from air.

xiantang avatar xiantang commented on September 27, 2024

just use the document one. at end of the day, i will update the document.

from air.

kz23szk avatar kz23szk commented on September 27, 2024

Currently, I can't install github.com/cosmtrek/air、 but will the module name be github.com/air-verse/air in the end?
I want to know which one it will be.

from air.

franckffv avatar franckffv commented on September 27, 2024

For me, I had to replace github.com/cosmtrek/air@latest with github.com/air-verse/air@latest in my Docker Compose, as the URL github.com/cosmtrek/air redirects to github.com/air-verse/air

from air.

silverwind avatar silverwind commented on September 27, 2024

This change broke all past versions of air as it's no longer possible to go install anything but the latest version where module path matches repo path. Go module system is broken by design 🤮.

from air.

nevinsm avatar nevinsm commented on September 27, 2024

A proper fix for this will require some git history rewriting. The go module system is designed to be stable so changing the name like this will cause these expected integrity issues. You will need to rewrite references in all the commits so that all tags have the new github.com/air-verse/air instead of github.com/cosmtrek/air for module references. The same with the runner references and any other submodules.

e.g.
v1.49.0 https://github.com/air-verse/air/blob/v1.49.0/go.mod#L1

should look like v1.52.2 https://github.com/air-verse/air/blob/v1.52.2/go.mod

Should be doable with git filter-repo --replace-text <(echo 'github.com/cosmtrek/air==>github.com/air-verse/air'). Be aware that rewriting git history can have seriously bad side effects.

It might be better to leave v1 up at github.com/cosmtrek/air and make air-verse/air the v2 release with the original repo archived instead of redirecting. Either way the git history will need some love and the project overall will be in a messy state until this is resolved.

from air.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.