Non-atomicity of operations about ibc-go HOT 4 CLOSED

duplicate of cosmos/cosmos-sdk#6370?

It's different actually. cosmos/cosmos-sdk#6370 as I understand it is related to the multi-store design of using multiple IAVL trees (see cosmos/cosmos-sdk#6370 (comment)). This is around how we are committing state and only rolling back at the transaction level rather than any time a sub-method returns an error.

from ibc-go.

Thanks @andrey-kuprianov. ADR 033 (#7459) could make the calls between different modules atomic. I can update the ADR to indicate that.

Within a single module, the module developer would still need to guarantee atomicity.

Your second suggestion could be addressed with something like Begin, Commit and Rollback transaction isolation methods on Context. It's not a bad idea to introduce those, but developers would still need to use them correctly.

I don't think we should require all methods to call Commit although maybe others have a different opinion.

Do you think that maybe the ADR 033 inter-module isolation would address this well enough?

from ibc-go.

duplicate of cosmos/cosmos-sdk#6370?

from ibc-go.

@andrey-kuprianov thank you for the write up!

In relation to the problem scenario, a recent change in cosmos/cosmos-sdk#7968 should definitely prevent the bug (if the bank code changed to allow an error to be returned) from occurring since we now panic if that scenario occurs.

This is definitely something that should at least be well documented since the fix on our side had not come from consideration of this problem.

from ibc-go.