Comments (4)
duplicate of cosmos/cosmos-sdk#6370?
It's different actually. cosmos/cosmos-sdk#6370 as I understand it is related to the multi-store design of using multiple IAVL trees (see cosmos/cosmos-sdk#6370 (comment)). This is around how we are committing state and only rolling back at the transaction level rather than any time a sub-method returns an error.
from ibc-go.
Thanks @andrey-kuprianov. ADR 033 (#7459) could make the calls between different modules atomic. I can update the ADR to indicate that.
Within a single module, the module developer would still need to guarantee atomicity.
Your second suggestion could be addressed with something like Begin
, Commit
and Rollback
transaction isolation methods on Context
. It's not a bad idea to introduce those, but developers would still need to use them correctly.
I don't think we should require all methods to call Commit
although maybe others have a different opinion.
Do you think that maybe the ADR 033 inter-module isolation would address this well enough?
from ibc-go.
duplicate of cosmos/cosmos-sdk#6370?
from ibc-go.
@andrey-kuprianov thank you for the write up!
In relation to the problem scenario, a recent change in cosmos/cosmos-sdk#7968 should definitely prevent the bug (if the bank code changed to allow an error to be returned) from occurring since we now panic if that scenario occurs.
This is definitely something that should at least be well documented since the fix on our side had not come from consideration of this problem.
from ibc-go.
Related Issues (20)
- Wait for all async acks to be returned before writing compiled acknowledgement to state
- Add `WriteAcknowledgement` function on channel keeper
- On async acks, store the full packet in core IBC
- Remove capability migration from ICS27
- Replace `TimestampAtHeight` with `TimeoutElapsed` interface on light client module
- Implement routeMultiPacketData
- Wire Eureka packet handler to Msg Server HOT 2
- Modify Endpoint to have the merkle prefix
- Decide on handling of ICA controller middleware
- Document handshake vs packet route usage (reasoning) HOT 1
- Remove mock modules from simapp binary app.go
- Transfer unwind fails to broadcast tx when using CLI HOT 1
- Inefficient construction of packet data in msg transfer
- Application callback testing should rely on individual callback rather than full stack
- Do not look-up channel twice in Timeout flows
- Refactor test flow for message server
- Remove capabilities
- Add CLI to submit tx with `MsgProvideCounterparty`
- Add gRPC query for `Counterparty` for a given client identifier HOT 3
- Add CLI query to return `Counterparty` for a given client identifier HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ibc-go.