Comments (4)
Reecepbcups
commented on July 17, 2024
@dferendo Thanks for the report. This change was not intentional as I can see.
The only file that was modified with any reference to abci.ResponseQuery is:
git diff modules/async-icq/v7.0.0 modules/async-icq/v7.1.1 -- modules/async-icq/keeper/relay.go > ~/Desktop/relay.diff
A new applyFuncIfNoError was added but nothing in the function indicates to me why it would swap key / value pairings here. executeQuery remains untouched... hmm
Did the function previously panic on v7.0.0?
from ibc-apps.
dferendo
commented on July 17, 2024
No, the function was a normal balance query and the data is still correct, just stored in the wrong variable.
from ibc-apps.
dferendo
commented on July 17, 2024
Looking more into it, it seems that SerializeCosmosResponse is returning different bytes between the two versions. We checked the data in this unit test.
v7.0.0 returns
eyJkYXRhIjoiQ2dRNkFoSUEifQ==
v7.1.1 returns
eyJkYXRhIjoiQ2dReUFoSUEifQ==
We used base64 encoding to obtain the above base64.StdEncoding.EncodeToString(bz).
from ibc-apps.
migueldingli1997
commented on July 17, 2024
Turns out this particular unit test is mostly likely returning different bytes because of the address which is different for each test run. That being said we're still experiencing this issue but haven't narrowed it down enough.
from ibc-apps.
Related Issues (20)
- The name router is ambiguous given its usage in other contexts
- All: label scheme to track issues separately from other sub repos
- async-icq demo controller chain implementation should live in this repo
- ibc-hooks doesn't always return ack,err when it should
- Make router.getReceiver public HOT 2
- Update integration docs HOT 4
- `polytone` should be imported to `ibc-apps` repo. HOT 1
- Update async-icq to ibc-go/v8 HOT 1
- question(ibc-hooks): incentives to relay wasm hooks HOT 1
- test: PFM test case for CI job `ictest-forward` is failing on main HOT 3
- Remove gogoproto replace statements for v8 HOT 3
- Consider updating PFM references
- add broken link check CI HOT 2
- backport: link lint & spell checking for all branches
- doc: IBC Hooks counter smart contract README contains misleading explanation HOT 1
- adding & importing ibc-rate-limit cleanup
- chore: remove `IBCMiddleware.refundTimeout` as it is no longer used HOT 2
- middleware: staking
- Migrate away from deprecated x/params module HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ibc-apps.