Comments (8)
As Ethan pointed out correctly, Split @cosmwasm/sdk into Cosmos SDK and CosmWasm functionality, such that CosmWasm becomes optional is independent of this ticket. I created #182 for that. The order of #179 and #182 does not really matter technically.
from cosmjs.
@davepuchyr Under which name would you like to have the BCP Cosmos SDK 0.38 package?
@iov/cosmos-sdk
?
Yes, @iov/cosmos-sdk
, please.
from cosmjs.
This sounds good.
Happy to hand off the @cosmwasm/bcp experiment to iov-core if they want to maintain it, integrate it in their wallet or in any way make real use of it.
And yes, I also agree on refactoring the faucet to just use @cosmwasm/sdk (bank).
from cosmjs.
However, I am not sure about
Split @cosmwasm/sdk into Cosmos SDK and CosmWasm functionality, such that CosmWasm becomes optional
We are talking about making a new repo to be modular and extensible, pulling in parts of iov-core and cosmwasm-js and others and making sure this is extensible for other modules. I would leave these as is here (working for all out 0.38-based cosmwasm releases) and do the refactoring on the new branch which will have plenty of redesign tasks as well. Unless you think there is a benefit to refactoring here first. (In any case, this is a separate ticket - bcp stuff is a full 👍)
from cosmjs.
The line of PRs #183, #184 and #186 does step 4 and 2 first. So we have no ERC20 tokens on BCP and the faucet after that.
I postponed step 1 and 3 since it is not trivial to refactor the faucet. It required one of those two options:
- Reimplement the token handling (COMS <-> ucosm) in the faucet
- Only work on the native unit (e.g. ucosm) and adapt a lot of documentation
from cosmjs.
@davepuchyr Under which name would you like to have the BCP Cosmos SDK 0.38 package? @iov/cosmos-sdk
?
from cosmjs.
Package is prepared. Move depends on #202
from cosmjs.
BCP package copied to IOV Core at tag v0.20.0: iov-one/iov-core#1440. Once we deleted it from here, this ticket is done.
from cosmjs.
Related Issues (20)
- AminoMsgTransfer is not supporting Memo of the message HOT 3
- StargateClient.searchTx doesn't work if you passing KV-array HOT 4
- "Invalid funds" issue HOT 2
- Support for cosmos-sdk v0.50, TM 0.38 HOT 4
- blockResults: Input not in int53 range HOT 1
- DirectSecp256k1HdWallet slow to sign a transaction HOT 9
- Chore: Typo in getContractInfo doc comments
- bug: @cosmjs/stargate missing denomHash method
- ERROR Broadcasting transaction failed with code 7 (codespace: sdk). Log: at SigningStargateClient.broadcastTx HOT 1
- Error: Broadcasting transaction failed with code 4 (codespace: sdk). Log: signature verification failed; please verify account number (3) and sequence (3)
- How to create a validator using @cosmjs/stargate library?
- [Feature]: Allow extends functionality with withExtension method.
- Find strategy to remove libsodium being bundled HOT 3
- Remove wallet encryption features and ed25519 crypto HOT 1
- What is exact usage of “signDirect” and “sign”? HOT 6
- Error: Invalid string. Length must be a multiple of 4 HOT 2
- Can't change Authz expiration past block time HOT 3
- Does recieving Transaction result means tx block is mined? HOT 2
- Is there way to verify signature without passing public key? HOT 3
- Cannot pass page/per_page/order_by parameters to StargateClient.searchTx
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cosmjs.