Giter Club home page Giter Club logo

Comments (4)

nooomski avatar nooomski commented on May 27, 2024

I like this, but how do we make sure this is updated after a governance proposal changes the param? Responsibility of chain.json maintainers?

from chain-registry.

JeremyParish69 avatar JeremyParish69 commented on May 27, 2024

I like this, but how do we make sure this is updated after a governance proposal changes the param? Responsibility of chain.json maintainers?

Is this something the lens tool could verify? and then have a script to submit a change if needed?

from chain-registry.

JeremyParish69 avatar JeremyParish69 commented on May 27, 2024

What should be the unit of duration? It probably goes technically always goes by number of blocks, but we'll probably also want an estimated time duration. And in what units should that time be? I suppose day is common enough, but we may end up having to change to hour, and seconds would be best unit with very high precision. Should it be a number with assumed unit? Or allow for a regex'd string? or some kind of datetime format?

I might propose:

"staking": {
  "staking_tokens": [
    {
      "denom": "uosmo",
      "lock_duration": {
        "blocks": 12345678,
        "time": "14 days"
      }
    }
  ]
}

why did I put the duration inside the staking token object? same reason as why the staking tokens is an array and not a single denom: in case different tokens have different locking durations.
E.g., ION staking is not for the chain, but might be nice to be able to record that here.

Alternatively, we could go with more assumptions (like staking always describing chain security--which might be best), then we could also do:

"staking": {
  "staking_tokens": [
    {
      "denom": "uosmo"
    }
  ],
  "lock_duration": {
    "blocks": 12345678,
    "time": "14 days"
  }
}

from chain-registry.

JeremyParish69 avatar JeremyParish69 commented on May 27, 2024

Should we change the entire staking section to look like this?
osmosisd q staking params

bond_denom: uosmo
historical_entries: 10000
max_entries: 7
max_validators: 118
min_commission_rate: "0.050000000000000000"
min_self_delegation: "0"
unbonding_time: 1209600s

from chain-registry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.