Giter Club home page Giter Club logo

Comments (15)

daniel-jonathan avatar daniel-jonathan commented on May 13, 2024

Yes, we have the initial fixes in place. I would like to run some tests and ensure some cleanups get in there. You should see it tomorrow if not later tonight :)

from material.

cohix avatar cohix commented on May 13, 2024

Beautiful thank you!

from material.

daniel-jonathan avatar daniel-jonathan commented on May 13, 2024

@cohix Still testing away, should be done soon. All the best and sorry for any inconvenience.

from material.

cohix avatar cohix commented on May 13, 2024

@DanielDahan Are you aware of the bug in MaterialButton in this block:

private func prepareBackgroundColorView() {
        backgroundColorView.translatesAutoresizingMaskIntoConstraints = false
        backgroundColorView.layer.masksToBounds = true
        backgroundColorView.clipsToBounds = true
        backgroundColorView.userInteractionEnabled = false
        insertSubview(backgroundColorView, atIndex: 0)
        Layout.expandToParent(self, child: backgroundColorView)
    }

Where the insertSubview line fails with lldb?

from material.

daniel-jonathan avatar daniel-jonathan commented on May 13, 2024

Can you make an issue for that and I will look into it :)


Daniel Dahan

M: +1 647.627.0770
Skype: djondahan

On Sep 18, 2015, at 1:46 PM, Connor Hicks [email protected] wrote:

@DanielDahan https://github.com/danieldahan Are you aware of the bug in MaterialButton in this block:

backgroundColorView.translatesAutoresizingMaskIntoConstraints = false
backgroundColorView.layer.masksToBounds = true
backgroundColorView.clipsToBounds = true
backgroundColorView.userInteractionEnabled = false
insertSubview(backgroundColorView, atIndex: 0)
Layout.expandToParent(self, child: backgroundColorView)
}

Where the insertSubview line fails with lldb?
—
Reply to this email directly or view it on GitHub https://github.com/GraphKit/MaterialKit/issues/46#issuecomment-141517811.

from material.

cohix avatar cohix commented on May 13, 2024

@DanielDahan done!

from material.

daniel-jonathan avatar daniel-jonathan commented on May 13, 2024

thank you :)


Daniel Dahan

M: +1 647.627.0770
Skype: djondahan

On Sep 18, 2015, at 1:51 PM, Daniel Dahan [email protected] wrote:

Can you make an issue for that and I will look into it :)


Daniel Dahan

M: +1 647.627.0770
Skype: djondahan

On Sep 18, 2015, at 1:46 PM, Connor Hicks <[email protected] mailto:[email protected]> wrote:

@DanielDahan https://github.com/danieldahan Are you aware of the bug in MaterialButton in this block:

backgroundColorView.translatesAutoresizingMaskIntoConstraints = false
backgroundColorView.layer.masksToBounds = true
backgroundColorView.clipsToBounds = true
backgroundColorView.userInteractionEnabled = false
insertSubview(backgroundColorView, atIndex: 0)
Layout.expandToParent(self, child: backgroundColorView)
}

Where the insertSubview line fails with lldb?
—
Reply to this email directly or view it on GitHub https://github.com/GraphKit/MaterialKit/issues/46#issuecomment-141517811.

from material.

cohix avatar cohix commented on May 13, 2024

No worries. Good work guys :)

from material.

kaushik-zapyle avatar kaushik-zapyle commented on May 13, 2024

Is this fixed yet?

from material.

daniel-jonathan avatar daniel-jonathan commented on May 13, 2024

@kaushik-zapyle Currently the development branch works on iOS 9 with swift 2. There seems to be an issue that @cohix is facing, and at the moment, not reproducible on our end. There isn't an official release right now with iOS 9 support, as we are ensuring that there are not any edge cases we have not yet had a chance to expose. Have you tried the development branch within your project?

from material.

kaushik-zapyle avatar kaushik-zapyle commented on May 13, 2024

So pod install for development branch gives me unable to find specification for MaterialKit.

from material.

cohix avatar cohix commented on May 13, 2024

The pod name is MK

from material.

daniel-jonathan avatar daniel-jonathan commented on May 13, 2024

@cohix thank you :)

from material.

cohix avatar cohix commented on May 13, 2024

@DanielDahan No worries :)

from material.

kaushik-zapyle avatar kaushik-zapyle commented on May 13, 2024

Thank you... :) 👍

from material.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.