Giter Club home page Giter Club logo

Comments (8)

coryhouse avatar coryhouse commented on July 16, 2024

I left it out initially because it's not always necessary.

That said, you're not the first to ask. Submit a PR and I'll consider adding it.

from react-slingshot.

coryhouse avatar coryhouse commented on July 16, 2024

If others really feel strongly about whether React Router belongs in the kit, this is the place to chime in...

from react-slingshot.

attilad avatar attilad commented on July 16, 2024

Actually one of the things I like about your kit is that it DOESN'T include it. I use React Router sometimes but I don't need it for every project.

from react-slingshot.

S1E- avatar S1E- commented on July 16, 2024

But it is always easier to remove a functionality than adding it.
On 28 Feb 2016 8:25 am, "Attila DeLisle" [email protected] wrote:

Actually I like your kit because it DOESN'T include it. I use React Router
sometimes but I don't need it for every project.


Reply to this email directly or view it on GitHub
#57 (comment)
.

from react-slingshot.

attilad avatar attilad commented on July 16, 2024

That's a good point.

from react-slingshot.

PetaPetaPeta avatar PetaPetaPeta commented on July 16, 2024

It would be nice to have it included along with a toggle function for turning it on or off.

from react-slingshot.

coryhouse avatar coryhouse commented on July 16, 2024

Great points. I'm open to it if someone submits a pull request. One important point is the example app should be enhanced to have simple navigation in order to display the router working.

from react-slingshot.

coryhouse avatar coryhouse commented on July 16, 2024

Added in 2.0 release

from react-slingshot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.