Comments (8)
I left it out initially because it's not always necessary.
That said, you're not the first to ask. Submit a PR and I'll consider adding it.
from react-slingshot.
If others really feel strongly about whether React Router belongs in the kit, this is the place to chime in...
from react-slingshot.
Actually one of the things I like about your kit is that it DOESN'T include it. I use React Router sometimes but I don't need it for every project.
from react-slingshot.
But it is always easier to remove a functionality than adding it.
On 28 Feb 2016 8:25 am, "Attila DeLisle" [email protected] wrote:
Actually I like your kit because it DOESN'T include it. I use React Router
sometimes but I don't need it for every project.—
Reply to this email directly or view it on GitHub
#57 (comment)
.
from react-slingshot.
That's a good point.
from react-slingshot.
It would be nice to have it included along with a toggle function for turning it on or off.
from react-slingshot.
Great points. I'm open to it if someone submits a pull request. One important point is the example app should be enhanced to have simple navigation in order to display the router working.
from react-slingshot.
Added in 2.0 release
from react-slingshot.
Related Issues (20)
- Use redux-saga
- npm run remove-demo doesn't work
- Terminal font becomes invisible after npm start
- Error running 'npm install' HOT 1
- Switch Redux logic setup to use Redux Toolkit HOT 4
- Involving Database HOT 4
- why there are yarn.lock and package-lock.json both present? HOT 6
- Implementation of redux-persist with react-slingshot HOT 5
- [WARNING] Removing the demo app also removes files that do not belong to the demo app
- Get error when execute "npm start" command. HOT 1
- Required Information about peripheral files. HOT 2
- Update README about python version HOT 1
- Refused to execute inline script because it violates the following Content Security Policy directive:
- facing issue while npm run setup HOT 2
- Opentest issue
- npm run on production environment
- Add Flow please
- npm ERR! [email protected]
- jest: not found
- Build 16x fails not 18x or 20x
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-slingshot.