Giter Club home page Giter Club logo

Comments (2)

corydolphin avatar corydolphin commented on August 15, 2024

Hey Daniel,

When used as a decorator, flask-Cors should not intercept exceptions or
alter them in any way. In order to get the expected behavior of adding Cors
headers to your error messages, decorate your error handler.

I will investigate more tonight to make sure it is doing what I expect! And
see if there is anyway to make it better. In the mean time, I encourage you
to use the extension, which should be simpler, and correctly wrap
exceptions.

Cheers,
Cory
On Sun, Apr 5, 2015 at 5:41 PM Cory Dolphin [email protected] wrote:

Hey
On Sun, Apr 5, 2015 at 11:08 AM Daniel Manson [email protected]
wrote:

Suppose I have:

@app.route('/doit')@cross_origin(origins='')def doit():
raise CustomException("owch!")
@app.errorhandler(CustomException)def handle_custom(err):
return str(err)

Surely the expected output should be the error page with cors headers?
But this is not what I find: I get an empty response with the 4xx error
code and nothing else (and no stacktrace on the server).

If this is intended behavior it should be made much clearer somewhere in
the docs as it confused me for a long time (though admittedly I am
completely new to flask cors and http error handling). Ideally though, the
expected behavior should be implemented, i.e. the error handler should
check the route function to see what cors it had intended to supply and
then provide them on the error response.


Reply to this email directly or view it on GitHub
#120.

from flask-cors.

lambdaq avatar lambdaq commented on August 15, 2024

@corydolphin any plans to add CORS to exceptions?

I am debugging a tricky exception on Chrome, without CORS, I can not see the tracebacks.

from flask-cors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.