Comments (3)
My 2 cents:
It is definitely something we need to fix. GetRules
shouldn't be impacted by that user manager lock.
I think it is fine to read the snapshot as you mentioned, we might not have the up-to-date rule groups at each ruler but it is ok since we do eventual consistency. And we have the global rules merge, too.
from cortex.
Maybe we can snapshot the tenant's RuleGroups before updating the manager and we read from have GetRules
read from the snapshot when SyncRuleGroups
is running
from cortex.
Thanks @yeya24 , I will try to create a PR to address this issue.
from cortex.
Related Issues (20)
- Add retry on prometheus list rules HOT 2
- Pagination support for Ruler and Alertmanager resource listing APIs
- `Terminated` state results in unhealthy ingesters
- AlertManager loda templates from sidecar HOT 3
- Query Frontend: queries with negative offset should check whether it is cacheable or not HOT 2
- [Security Self Assessment] Cortex HOT 2
- API for delete metric labels HOT 1
- Cortex 1.16.0 Upgrade Error:LabelValues() from merge generic querier for label HOT 8
- "context canceled" is Added as a Span Event on `cortex.ingester/QueryStream` Trace HOT 2
- Querying basis on filter and getting metrics we should'nt get HOT 5
- CVEs in Cortex 1.16.0 HOT 2
- The 'alertmanager_max_alerts_count' is not functioning properly HOT 5
- 1.16.0 Store Gateway Query stats - ability to disable HOT 2
- multilevel cache with inmemory and redis HOT 7
- CNCF TOC follow up on project health HOT 2
- "maxFailure (quorum) on a given error family" error: consider different wording HOT 1
- SGW Redis client side cache HOT 1
- Allow runtime config to be optionally loaded with strict or non-strict unmarshaling HOT 3
- Seems the CodeQL is breaking in master:
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cortex.