Implement proper config initialization for default values about go-ftw HOT 6 CLOSED

I suspect that it will also be natural to fix the issue that config can only be passed as global variables right now. This is awkward when running tests programmatically. I had added some config knobs related to HTTP previously but probably all the config should be merged into that, with the CLI passing in values same as it currently does.

from go-ftw.

What about

from go-ftw.

Global variables are awkward to use programmatically, these functions being called new but not returning any actual config seems to show that they aren't very idiomatic.

The biggest problem would be to run multiple ftw in parallel which seems reasonable to support.

from go-ftw.

What I was going for was a function that can is used by both the commands and the tests. With NewConfigFromString we would just repeat the default values for the tests. I don't like repeating defaults in different places, that always comes back to haunt you.

from go-ftw.

Following #123 merge, I think we can now move to the second part of this fix. I guess adding the command line config variables that will affect all tests to the config is the right choice?

from go-ftw.

Yes, I think so.

from go-ftw.