Comments (6)
I suspect that it will also be natural to fix the issue that config can only be passed as global variables right now. This is awkward when running tests programmatically. I had added some config knobs related to HTTP previously but probably all the config should be merged into that, with the CLI passing in values same as it currently does.
from go-ftw.
What about
Line 88 in e77aee3
from go-ftw.
Global variables are awkward to use programmatically, these functions being called new but not returning any actual config seems to show that they aren't very idiomatic.
The biggest problem would be to run multiple ftw in parallel which seems reasonable to support.
from go-ftw.
What I was going for was a function that can is used by both the commands and the tests. With NewConfigFromString
we would just repeat the default values for the tests. I don't like repeating defaults in different places, that always comes back to haunt you.
from go-ftw.
Following #123 merge, I think we can now move to the second part of this fix. I guess adding the command line config variables that will affect all tests to the config is the right choice?
from go-ftw.
Yes, I think so.
from go-ftw.
Related Issues (20)
- -a HOT 1
- Document Migration from ftw HOT 4
- Ability to define custom request headers for logmarker requests HOT 2
- What are the log format requirements for ftw? HOT 14
- Dependency Dashboard
- Provide a proper way to define expected response data HOT 5
- httpbin does not reflect requests perfectly HOT 4
- Add a flag or configuration value to test based on rule attributes
- Allow precise configuration of raw request body HOT 1
- Make the include list configurable in ftw.yaml
- Make it possible to run the same test against multiple URIs
- Go install fails (directives to be interpreted differently than if it were the main module) HOT 6
- Throttle request speed option HOT 1
- Action Required: Fix Renovate Configuration
- Implement missing settings from schema HOT 1
- Remove magefile? HOT 3
- Regression test loading broken in 1.0.0 HOT 1
- New name for go-ftw HOT 10
- Add support for matrix / parameterization HOT 1
- Add support for self-update
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-ftw.