Comments (13)
Interesting. However the "libwertc.so" included in the project is the static library of a customized version of the webrtc library. This is because the original Obj-C code lacks support for MediaStream events and I added it but it's not included in the upstream project:
https://webrtc-codereview.appspot.com/50109004/
Anyhow I will come back to this proposal once I come back from holidays ;)
from cordova-plugin-iosrtc.
+1
I suggest to add the hook at pre_build
from cordova-plugin-iosrtc.
I'll need some time before I can handle this issue. Please, patience.
from cordova-plugin-iosrtc.
PR are welcome!! ;)
from cordova-plugin-iosrtc.
Got it all working but there is some custom code apparently in the version of WebRTC that this library uses that isn't in WebRTC upstream so it isn't able to build (missing RTCMediaStreamDelegate which was added by @ibc). Tried removing the pointers to this custom code to get it to build and hit more problems, so I'm going to try to figure out what @ibc added to this custom version of WebRTC so I can replicate it
https://github.com/contra/cordova-plugin-iosrtc
from cordova-plugin-iosrtc.
We modified the Google's WebRTC ObjC code in order to implement and fix the missing "addtrack" and "removetrack" events of RTCMediaStream
. The patch was proposed but Google did not accept it because the WebRTC spec is removing MediaStream
tracks events:
https://webrtc-codereview.appspot.com/50109004/
from cordova-plugin-iosrtc.
@ibc is that required for iosrtc to function or is it an enhancement?
from cordova-plugin-iosrtc.
Please read the comments in the patch above. It fixes the MediaStream behavior so it is not just an enhancement.
from cordova-plugin-iosrtc.
I would suggest as an intermediate solution, to use git LFS for the large file. The repository is getting really slow to clone...
from cordova-plugin-iosrtc.
If you are cloning via git you can use --depth 1
to avoid getting the entire history. We now patch libWebRTC even more, so we can't use a generic build.
from cordova-plugin-iosrtc.
@saghul that doesn't invalidate what I'm suggesting. Github itself warns about files bigger than 50MB. Did you see how git LFS works? This is sponsored by github.
from cordova-plugin-iosrtc.
I'm aware of LFS. This is not my project, but if it were, I wouldn't use LFS until it's absolutely needed. See the drawbacks here: https://medium.com/@megastep/github-s-large-file-storage-is-no-panacea-for-open-source-quite-the-opposite-12c0e16a9a91#.85wtfitph
I would have already run into the problem of not being able to PR the file stored on LFS (the current build was contributed by me in a PR).
from cordova-plugin-iosrtc.
@saghul you're right, it doesn't look like we should use it here.
from cordova-plugin-iosrtc.
Related Issues (20)
- Implementing Mediapipe Pose on ionic IOs using iosRTC HOT 1
- Add flashlight control HOT 4
- Add video border radius support HOT 1
- Enable/Disable track from Receiver/Sender is broken in case of use with Janus Videoroom HOT 5
- Getting error in connecting ios device microphone and video in openvidu ionic HOT 5
- RTCRtpSender not have DTMF properties and createDTMFSender deprecate HOT 4
- PrecompileSwiftBridgingHeader fails after first successful build ('WebRTC/RTCAudioSource.h' file not found) HOT 9
- Pretty bad H264 performance after upgrading to iOS 15.4 HOT 24
- blank screen issue HOT 2
- HTML element over video HOT 1
- Own audio shut down during video conference HOT 5
- App failing to build because of the plugin HOT 4
- navigator.mediaDevices is undefined HOT 2
- cordova iosrtc app crash on iphone device - 'NSInternalInconsistencyException', HOT 12
- Twilio VideoJs adaptive simulcast undefined error, because of missing width and height properties from MediaTrackSettings HOT 6
- Call canceled when callee pickup the phone. HOT 3
- Bug: Can't install plugin on latest cordova/xcode HOT 3
- Build Failed HOT 8
- PluginMediaStreamRenderer.mediaStreamChanged() has multithreading race condition
- iOS 17.5 background mode, app suspended now, call audio stops. HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-plugin-iosrtc.