Comments (4)
FYI: The reason why there are duplicates is because ShareStateAndSyncAccountsFlow sends the accountInfo that belongs to the Party you are sending to.
ShareStateAndSyncAccountsFlow
doesn't do any checking to see if the accountInfo belongs to the node/Party you are sending to.ReceiveStateAndSyncAccountsFlow
doesn't check to see if the key exists before persisting it.PublicKeyHashToExternalId
doesn't have any constraints to stop you storing duplicates.
from accounts.
Thanks for the heads up - we'll fix this. Cheers @opticyclic !
from accounts.
In Corda 4.3 PublicKeyHashToExternalId
doesn't allow dupes anymore, so this method should only ever return one result, or null. This PR (corda/corda#5411) in the Corda repo adds an API which allows us to look up an account by public key. It will be merged next week - at which point the highlighted code can be removed in favour of a call to the new API externalIdForPublicKey
. Regarding: ShareStateAndSyncAccountsFlow
and ReceiveStateAndSyncAccountsFlow
, I'll make the changes you suggested. Cheers
from accounts.
Fixed + clarified in this commit: 4cd8f9b
Thanks for the heads up @opticyclic !
from accounts.
Related Issues (20)
- Which Versions Of Corda Are Supported?
- Unable to build Accounts since today HOT 2
- Cannot resolve symbol 'r3'
- https://download.corda.net/maven/corda-dependencies/ doesnt exist HOT 1
- Could not resolve net.corda:corda-core:4.3-RC01
- IDEA Compile Directories Are Not Ignored
- How to extend AccountInfo ContractState HOT 7
- Share data between accounts on same node HOT 3
- Could not find com.r3.corda.lib.accounts:accounts-flows:1.0-RC04. HOT 1
- Make Accounts Easier To Use HOT 7
- Improvement Suggestion
- Incorrect result with Token intergration using Accounts HOT 3
- Accounts authentication in Corda's node HOT 1
- Empty account_to_state_refs table HOT 7
- Incorrect result while transferring token from Node containing account HOT 10
- Advice on implementing equivalent to FlowLogic.ourIdentity HOT 1
- Schema-validation: wrong column type encountered in column [external_id] in table [XX.account_to_state_refs]
- Send attachments to accounts
- SendKeyForAccountFlow to return AnonymousParty
- The KeyManagementBackedAccountService implementation fails to retrieve the accounts when the number of accounts exceeds DEFAULT_PAGE_SIZE
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from accounts.