Comments (11)
I added the label "bug" because:
- there are duplicate SQL queries that have an impact on performance
- when organization or child record is long, the display can become quite hard to read
from coral.
I disagree that this is a bug. A bug is when a feature breaks. This isn’t a break, it’s just something that could perhaps be done better.
Steve
From: Paul Poulain <[email protected]mailto:[email protected]>
Reply-To: Coral-erm/Coral <[email protected]mailto:[email protected]>
Date: Tuesday, May 3, 2016 at 7:10 AM
To: Coral-erm/Coral <[email protected]mailto:[email protected]>
Subject: Re: [Coral-erm/Coral] Review the "helpful links" on the right (#35)
I added the label "bug" because:
- there are duplicate SQL queries that have an impact on performance
- when organization or child record is long, the display can become quite hard to read
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-216508954
from coral.
While I agree it's not a critical problem, I still think it's a bug, and not en enhancement. We've loaded large packages, with a lot of titles, and the performances are awful & the display ugly.
Here is a screenshot:
- you can see there are duplicated informations
- they've different labels (Related product: and Child Record(s) ), that's hard to understand for users.
- on a DB with packages having x00 of title, the performance hit is really huge. We've removed the "helpful link" part on a sample DB with 230 000 resources, and it's obvious !
from coral.
Paul,
I still strongly disagree that these are bugs. I’m not trying to be difficult about it, and believe me, I am fully aware of the aspects you raise. But I think this is an important distinction for us in the SC to make and to have a shared understanding about (what is a bug vs. an enhancement).
Steve
from coral.
Le 03/05/2016 19:21, techsvcslib a écrit :
I disagree that this is a bug. A bug is when a feature breaks. This
isn’t a break, it’s just something that could perhaps be done better.
We can discuss for years of this topic I think. Most project solve this
by having different levels of bugs (blocking, critical, major, minor,
aesthetic,...) or having an other flag.
I've added many issues to github tracker, that you'll not consider as
bugs probably, but, for me, they are bugs:
#36 => it's a design issue
#29 => nothing is "broken", you
can use Coral. But I consider the behavior as illogical.
Even for #37, I have hesitated
to classify it as "bug" : it's a design issue like the #36 one.
I'd like to talk about this in a future meeting (will add the topic to
trello immediately)
Paul Poulain, Associé-gérant / co-owner
BibLibre, Services en logiciels libres pour les bibliothèques
BibLibre, Open Source software and services for libraries
from coral.
Paul,
I agree — we can argue about this for a while. Let’s plan to talk about this as a group at some point (the general issue of “bug” vs. “enhancement”).
Steve
from coral.
I would agree that the performance issues caused by trying to display hundreds/thousands of child record titles would be a bug. The existence of the helpful links section and the fact the same information is displayed in multiple locations of the same record is not a bug. We might be able to find agreement by being more specific in what we are pointing out as the feature in question.
from coral.
Can we craft a list of the entirety of things displayed in the helpful links section? Is it just print view, child records, organizations? I would be open to a conversation about other ways to provide this feature. For example, print view could be placed somewhere else within the display. Child resources, when the list gets long, could be linked to with something like a 'more children' link that could send the user to the search results page with results scoped to children of the selected record, and I could live without a second link to the related organizations.
from coral.
I think there is much more to the specific issue of display of child records than the performance issue. I still disagree that display of hundreds/thousands of child records causes performance issues and that this should be classified as a bug. By the way, we’ve locally dealt with this for at least three years as one of the few libraries who have been actively using parent/child relationships for large packages for a while, and there isn’t a huge performance problem with it in our instance.
Much more problematic than the performance issue is the actual display of the children. It’s not in any sensible order (e.g. alphabetical), and overall the display is way too long and cumbersome to use when hundreds of links get displayed. I’d prefer something more manageable like a link to export a title list of all children, or something like that.
Steve
from coral.
I like the idea for “More children” that you propose, Ben. Another thing that gets displayed in the helpful links is a link to the license. That’s also available within the Acquisitions tab so I’m ok with that not being in helpful links any more.
Steve
from coral.
This looks like a change that needs further discussion. Let's target it for a later release.
from coral.
Related Issues (20)
- JQuery version is affected by multiple cross site scripting vulnerabilities HOT 1
- Can CORAL send emails to the respective persons in Resource module issue tab? If yes then how it works? Please help. HOT 1
- How to take back up & restore of CORAL? Please help. HOT 2
- COUNTER 5 SUSHI platform parameter should be added HOT 4
- ubable to pass data to mysql using php HOT 1
- Using incorrect date format in resource cost history results in cost history data loss HOT 2
- coral_organizations.OrganizationHierarchy should have an ID column
- php 8.x review HOT 1
- Access Information Should be Repeatable HOT 1
- Unable to add a category to the module "Management" in CORAL version 2020.09 HOT 5
- Unable to delete an "Authentication Type" from the list in Admin in the Resources Module.
- Unable to add a "category" to the module "Management" in CORAL version 2020.09 HOT 1
- How do I enable the Dashboard on the Resources Module? HOT 2
- Does SUSHI connect on Localhost/Local IP? HOT 1
- Emails are not receiving HOT 2
- Next Run Date on SUSHI Services HOT 4
- Problem in Usage Statistics Module HOT 3
- SSL Certificate Issue in Usage SUSHI test on Ubuntu
- Permit issues for resource contacts
- Feature Request: Placing import buttons at the top of the Usage Statistics file review screen HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coral.