Comments (2)
We've been wanting to be able to "favorite" channels for a while, but in your case, it might be useful to actually "hide" channels instead. I'm thinking we could add a visibility
attribute (other name is more than welcome) to a conversation object and use that in any way we want in the user interface.
- Add a
visibility
attribute to https://github.com/convos-chat/convos/blob/main/lib/Convos/Core/Conversation.pm. This could be a number, where -1 = hide, 0 = normal, and let's say 100 could be favorite. This attribute must also be added to TO_JSON, and the relevant tests must be updated. - One hurdle is that there isn't any good way to change the Conversation object by the user, so we either need a new endpoint in https://github.com/convos-chat/convos/blob/main/public/convos-api.yaml and a new controller to update the given object, or we could just make a new command in https://github.com/convos-chat/convos/blob/main/lib/Convos/Core/Connection/Irc.pm#L37 to change the visibility, like
/visibility #convos -1
. If we go for the command, it would be nice to steal the command from other clients. - After that, we need new logic in https://github.com/convos-chat/convos/blob/main/assets/components/ChatSidebar.svelte to sort by
visibility
and hide those with -1. The -1 conversations should however appear if searched for and maybe we should display them ifnotifications
is above 0?
If anyone wants to work on this, then https://convos.chat/doc/develop should give you an idea on how to get started.
from convos.
This would be the new section in the menu - it can be hidden if there are no Favourites.
![favourites-menu](https://private-user-images.githubusercontent.com/2424140/271126855-9e65def0-0365-4f85-bef7-ced5a4e19acc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ1NjMxMTAsIm5iZiI6MTcwNDU2MjgxMCwicGF0aCI6Ii8yNDI0MTQwLzI3MTEyNjg1NS05ZTY1ZGVmMC0wMzY1LTRmODUtYmVmNy1jZWQ1YTRlMTlhY2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDEwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAxMDZUMTc0MDEwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjY5ZTJjN2FjMTE4OWY1NTVmNGIwMGJmZGZjNWY0ZjBjMjExMzdhMGZmNTcyNDM4ZmI0NmFhMjYwZWNjNTRiMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.A0im7dBWk7ucizl7q5u-rliE9qusCln_KanVKtdDBFE)
And this could be one option to make a channel a favourite, but I would need to figure out how that stores the state. I saw that disabling Notify me on new messages
on that section creates a new key in localStorage called convos:chat:wantNotifications
, so the same could be done for favourite? Where is that localStorage key coming from? Is it from the API?
![favourites-conversation-settings](https://private-user-images.githubusercontent.com/2424140/271126851-ec746d95-eab1-4b07-82c4-e6a5f3d9b185.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ1NjMxMTAsIm5iZiI6MTcwNDU2MjgxMCwicGF0aCI6Ii8yNDI0MTQwLzI3MTEyNjg1MS1lYzc0NmQ5NS1lYWIxLTRiMDctODJjNC1lNmE1ZjNkOWIxODUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDEwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAxMDZUMTc0MDEwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmY0YjQzMDFiMTY3YWU3N2Q3N2E1ZmJiNDNmNGY5ZWJkNzQ1OTg0MzNkNmM2YTgzMTdhMDVhNjU4MjkzN2UwOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Flle-2_qb5jeA76Jhq6q5u6Toe98Y6ivBN632lpaAZk)
from convos.
Related Issues (20)
- Stable version is bugged. HOT 16
- Bot support for Codeberg.org / Gitea HOT 4
- Admin email setting adds "mailto:" every time I press "save settings" HOT 2
- Login via LDAP with LLDAP server HOT 10
- Login with LDAP fails on first try HOT 1
- Asks for irc-libera on first connection even though a different default connection is configured HOT 1
- Emojis do not show up in Emoji picker and are delayed in the normal chat window HOT 13
- CMS theming not working with custom theme files HOT 3
- Option to join new video chat with Jitsi Meet HOT 2
- Option to minimize networks and user settings? HOT 1
- Force predefined list of networks?
- Version check wrong behavior HOT 1
- Can't install HOT 1
- Search function doesn't return new results HOT 1
- 7.16 version mismatch HOT 2
- Plugin Request - Sorting Channels like Discord Servers into Folders HOT 1
- Not listed on https://ircv3.net/software/clients HOT 1
- Container crashed due to invalid instruction in argon2.so, under Haswell or older HOT 6
- Figure out and fix "unknown/unknown" architecture for arm/v7 HOT 4
- Convos do not parse colour and/or control codes properly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from convos.