Giter Club home page Giter Club logo

Comments (2)

abyrd avatar abyrd commented on September 4, 2024

I now better understand the above mentioned "Please don't publish this project to a public artifact repository! " after reading discussion of Jigsaw modules from the heads of Sonatype and Maven: https://dzone.com/articles/java-automodules-considered-bad-for-your-health Here and in other articles they plead for people to completely avoid fully-automatic filename based automodules.

This post: https://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html comes to the conclusion that you should not upload an artifact with a module-info.java to a Maven repository unless all the required modules in that module-info.java also declare a module name, via module-info.java or at least via Automatic-Module-Name in the JAR manifest.

So we should only include the Automatic-Module-Name in the JAR manifest until our dependencies all specify a module name, then we can add a module-info.java. The question is then how we would build the library at all under Java 11 without a module-info.java.

Naming: They suggest all module names should be namespaced and probably based on Maven group+artifact coordinates. Generally, modules should be named in reverse-DNS style like Java packages, and ideally the name of the module is the shortest common prefix of all the packages it exports.

from kryo-tools.

abyrd avatar abyrd commented on September 4, 2024

Addressed in v1.5.0.

from kryo-tools.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.