How to set SK lang about gopay HOT 8 CLOSED

Hi. Thank you for your time.

What about stay strict and append only missing languages?

Language code Language
CS Czech
EN English
SK Slovak
DE German
RU Russian

from gopay.

It si your dicision. But what about ES, PL, HU, ................................
I think it is not necessary to be strict here. Fallback to default is common pattern and I thing Gopay will support it also in future. So setLang can be so simple as possible.

from gopay.

Hmm. Good point. But I still thing that strictness should be on library side. It's no difference for programmers, if they'll type properly values, otherwise it'll throw an exception.

I think this way is more clean. Also it's more predictable, because you know what you send to server. Fallbacks are not straightforward solutions, especially not for the beginners.

Do you agree? Would you mind prepare a PR for it?

from gopay.

I dont know how to make PR from GH fork. It is not so simple if I remember. But I am still against the strict mode here. Exception as exception. It is the same. If Gopay will throw an exception in future I believe it will be clean also for beginners. And every new language will need new release of this library. Strict mode is mainly about safety. This is not user friendly.
THX.

from gopay.

So I did PR. Now it is on you.

from gopay.

And what about change the exception to EN fallback in this method?

from gopay.

@camohub Sorry, I would like to maintain it as closed (strict) as possible. So no, no fallback. But thank you for your time.

from gopay.

Closed via #57

from gopay.