OSX and Homebrew about faktory HOT 18 CLOSED

@nicolas-besnard #20

from faktory.

Thank you all, Homebrew is live!

https://github.com/contribsys/faktory/wiki/Installation#osx

from faktory.

They have pretty solid instructions:
https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md

from faktory.

What about Docker ?

from faktory.

@mperham I can take a stab at this and report back 👍

from faktory.

For homebrew formulas, it's what @byt3smith linked. You just need to decide how you want to build the binaries. I'd probably suggest ghr for right now. It's free and it's reusable if you want to get fancy later

Option 1 - ghr
What you (Mike) would do as the author is remember (manually) to upload the binary from your mac on release or tag. GHR can be setup easily to help with this and I've done it before. This would save you from the complexity of the next option ...

Once you have it setup it's like: ghr v0.6.0 faktory. You just need to setup some OAUTH tokens.
You could also update your Makefile to output to an ignored bin directory to make this work a bit better with ghr because ghr takes a file or a path of files but not a list of files. But it seems to be ok with updating a release. For example:

ghr v0.6.0 faktory
ghr v0.6.0 faktory-cli
WARNING: found release (v0.6.0). Use existing one.--> Uploading:      faktory-cli

Because this project has two binaries.

Option 2 - Some CI Service
Find a CI option. Since a travis config is already done from #33, and it's Linux, you probably can't do it from Travis. I don't know how to do multi-environment (OS's) builds in Travis. CircleCI 2.0 seems to have killed their OSX env (idk) because they are going full docker. I had a travis.yml config started to do OSX builds but the dev loop is really slow because I'm on a free tier.
You could pay for buildkite or something.

The nice thing is that ghr can be used with CI. So once you have ghr setup, you can just have binaries uploaded whenever there's a commit to master or a tag to master? I don't know how you'd want this workflow setup but a post hooks for CI services are detailed on the ghr wiki.

Homebrew
No matter what, you need to decide how to own the Formula. You could create a tap under contribsys like some people do (me) and then have people tap that:

brew tap contribsys/tap
brew install faktory

Or you could do a PR to homebrew and try to get it in the official repo? I don't know how long that takes or if that's recommended anymore.

Cheers.

from faktory.

Ah interesting! I forked the homebrew-core repo and linked it to the Faktory tarball stored on git, so I must be attempting the last method you outlined (getting it into the official repo).

I haven't gotten very far yet, but the work is here: https://github.com/nycdavid/homebrew-core/tree/faktory

The ghr method seems interesting, I'd like to look into. Not sure how far I'd get, since I'm not the owner of the repo... 🤔

from faktory.

@squarism The process for doing a travis build on OSX should be nearly identical, you just need to add osx into the build matrix and then conditionally run pieces of your test, like this.

@nycdavid if you do write the Homebrew formula I think you'll probably have some magic to do with the gopath to make sure it builds from the right dependencies. Looking at another go project like nsq may or may not help.

from faktory.

@andrewstucki Ah okay, thanks for the tip! 🙂

from faktory.

@andrewstucki thanks!

from faktory.

@nycdavid Just a heads up, I took a look at the implementation this would need for homebrew and realized that building the dependencies for the generation binaries are a bit more complex than I would have thought, so I just took care of it: https://github.com/Homebrew/homebrew-core/pull/19897/files

from faktory.

@andrewstucki Oh nice, looks good 👍

from faktory.

wow 👏

from faktory.

@mperham not sure if/when this will get merged, so just in case it doesn't (due to the fact that faktory isn't fully stable?), feel free to grab the above code and throw it into a contribsys tap -- should at least let people use the formula in a relatively straightforward way.

from faktory.

@andrewstucki Looks like if I create contribsys/homebrew-faktory and we drop the right formulae there, people can access it with brew tap contribsys/faktory?

from faktory.

As much as I want the entire world to start working with it tomorrow, I would avoid official brew releases until 1.0. Faktory is still young and not stable yet.

from faktory.

I believe so. It's been awhile since I've used a third-party tap, but I think just dropping the faktory.rb that I submitted in the PR into the top-level of a repo like github.com/contribsys/homebrew would allow people to use it via brew tap contribsys/homebrew && brew install faktory per the directions @squarism outlined above.

from faktory.

@mperham I'll mention in the PR that still talking with the primary author of the project about whether he wants the formula in core or is fine creating his own tap.

from faktory.