OSC-8 link storage(?) broken for links generated with aerc colorize about contour HOT 3 CLOSED

@Yaraslaut Note this line from the spec:

The same id is only used for connecting character cells whose URIs is also the same.

So if you used a combination of the url and the id for the cache key, then you shouldn't have this problem.

You are right, essentially this is equivalent to using our own id, instead of user provided one

from contour.

We see this bug because colorize.c sets id for the url, some info about id you can find here: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
While initial intention is to use id only for Hover underlining we also use it to open links. When user opens a link, we search for it by id inside internal url cache, and since id is the same for all of them only first link is exist in the cache.

Possible solution is to ignore user specified id since we set it anyway, and when we count it internally then everything will go smooth
Maybe @christianparpart has a better idea

from contour.

@Yaraslaut Note this line from the spec:

The same id is only used for connecting character cells whose URIs is also the same.

So if you used a combination of the url and the id for the cache key, then you shouldn't have this problem.

from contour.