Giter Club home page Giter Club logo

Comments (10)

DaniRey avatar DaniRey commented on May 29, 2024 5

Hey @davidfateh

Although there is a workaround, it would be great if you could keep that issue open until instance parameters are implemented. This allows interested people to watch the issue and update their apps, as soon as the feature is available.

from apps.

davidfateh avatar davidfateh commented on May 29, 2024 1

I originally linked this PR because it would close out your first bullet point which is the initial folder. The other bullet points you mentioned are things we haven't considered yet. I've unlinked the PR for now so it won't close this issue.

Currently, as we work on the app framework, we have to divert some of our efforts to focusing on building out the underlying infrastructure. For these reasons we cannot always commit to building new features in the existing apps at the current time. We do plan to revisit the issues in the future but also welcome outside contributors to submit PRs with functionality they deem useful.

That being said, I believe functionality you are looking for is possible to implement but it would require customizing how the configuration screen inside of the app functions. You could, in theory, change the configuration screen to have even further customization on a per entry field basis.

from apps.

dufkaf avatar dufkaf commented on May 29, 2024

btw found original cloudinary integration by @michelbitter which was still done as extension and all the settings are of "instance" type there, at least the maxFiles with default value 1 makes better sense like this instead of being global setting now.

from apps.

dufkaf avatar dufkaf commented on May 29, 2024

Not sure why github now shows @davidfateh linked a pull request that will close this issue. As this should not close it, this is about instance parameters i.e. one set per each content type, that pull request won't solve it, it only adds installation parameter for starting folder, not instance one.

from apps.

dufkaf avatar dufkaf commented on May 29, 2024

Currently, as we work on the app framework, we have to divert some of our efforts to focusing on building out the underlying infrastructure.

Makes perfect sense, so allowing instance parameters again is 'building out underlying infrastructure' ?

You could, in theory, change the configuration screen to have even further customization on a per entry field basis.

I know how it worked with extensions. And it almost works like this with apps. You go to properties->appearance of specific field and pick Cloudinary app as appearance. On the same screen you could add instance parameters for extensions but not so for apps now. There is just empty space on the botom.
image

Yes I noticed you see fields linked to this app in app configuration screen but this is not primary way to link them (?) so the settings should probably be not there too. Even now you link them via appearance screen so instance parameters make best sense to be set there too like it was with extensions. Or maybe you are going this way? To kill the appearance selection for apps and do everything on app configuration screen?

For these reasons we cannot always commit to building new features in the existing apps at the current time.

Sure, we are currently hosting this customized extension ourselves, I am just sending changes upstream. I do not expect you to develop new features to Cloudinary app yourself. But I hope accepting such pull request is OK.

from apps.

davidfateh avatar davidfateh commented on May 29, 2024

Hey @dufkaf,

I've discussed this situation with the team and we definitely see the value of having instance parameters added into apps as well. We are going to add that work to our backlog.

In the meantime I can offer you a workaround since you did mention you are running the customized version privately.

The workaround would be to customize the app's configuration screen to save additional information in the installation parameters about your selected fields. Then in the field component, you would read the app's installation parameters and see if there are any customizations you need to make to the field.

I hope this is helpful to you.

from apps.

davidfateh avatar davidfateh commented on May 29, 2024

Going to close this issue for now. Like mentioned above, the workaround is to save various settings into installation parameters.

from apps.

Grizzlien avatar Grizzlien commented on May 29, 2024

Hey @dufkaf and @davidfateh,

So is this an issue in general for apps? Apps does not support instance parameters, only extensions? Or did I missunderstand?
I'm also having trouble reading the instance parameters of an app. If I set default values in the app definition, sure they show up, but not the overrides set on the actual field.

from apps.

fabe avatar fabe commented on May 29, 2024

@Grizzlien Hey! Apps fully support instance parameters: https://www.contentful.com/developers/docs/extensibility/app-framework/instance-parameters/

If you have a problem with them, please open another issue or ask a question in our community Slack so our engineers can help you out :)

from apps.

Grizzlien avatar Grizzlien commented on May 29, 2024

@fabe

Maybe it's just when you use the dam-app-base it´s tricky? Maybe that base doesn´t support it.
Thanks I'll check it out

from apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.