Continue if not update service about shepherd HOT 6 CLOSED

Yes, we can probably have a better failure handling. I currently don't have the time to implement this though. Pull requests are always welcome!

from shepherd.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from shepherd.

Hey djmaze, I'd like to help you with this one, one of my services also fails to restart. The reason: In a swarm with 1 worker and 1 master I bind a local folder to the service, and only the master can access the local folder. The worker fails with invalid mount config for type "bind": bind source path does not exist: .... So its definitely an error with my deployment, but i think we can use this one to test error handling.

Here my docker-compose.yml:

---
version: '3.3'

services:
  links:
    image: selmatud/links:latest

    volumes:
      - ./urls.yaml:/opt/links/urls.yaml
    deploy:
      mode: global

the command docker service update links_links --image=selmatud/links:latest(which also will be executed from shephard) never finishes. If i add the argument --health-timeout 20s the command finishes. What do you think? Would this be an solution for this problem?

from shepherd.

@ljurk Hmm, does the --health-timeout argument also work when a service or the underlying image does not have healthchecks defined?

from shepherd.

Yes indeed, the image in the example above doesn't have healthchecks configured. But the task-state on the worker is rejected. I think the command docker service update tries to update the task while the desired state is not same to the current state. The argument health-timeout only limits this to certain time.

from shepherd.

I have recently opened source of my service updating scripts:
https://github.com/shizunge/gantry

It should not exit on errors.

Would you like to give it a try?

from shepherd.