CRI-Plugin crashes when defining other runtimes in imported config-file about containerd HOT 4 OPEN

You can use follow config to set spin runtime, and you can use containerd config default command to generate default config. hope can help you.

    [plugins.'io.containerd.cri.v1.runtime'.containerd]
      default_runtime_name = 'runc'
      ignore_blockio_not_enabled_errors = false
      ignore_rdt_not_enabled_errors = false

      [plugins.'io.containerd.cri.v1.runtime'.containerd.runtimes]
        [plugins.'io.containerd.cri.v1.runtime'.containerd.runtimes.spin]
          runtime_type = "io.containerd.spin.v2"
        [plugins.'io.containerd.cri.v1.runtime'.containerd.runtimes.spin.options]
          BinaryName = "/bin/containerd-spin-shim-v2"

from containerd.

Hi @lengrongfu ,
thank you for your comment.
The problem is however not to get a working config. I have that.
I am just reporting that if you set certain parameters in a config file that gets imported, the CRI plugin crashes, which seems like a bug to me.
I do not have a problem currently, this just seems faulty.

from containerd.

The error is in the containerd stdout/stderr when starting with your included config:

WARN[2024-04-04T18:30:37.688903174Z] failed to load plugin io.containerd.grpc.v1.cri  error="invalid plugin config: no corresponding runtime configured in `containerd.runtimes` for `containerd` `default_runtime_name = \"runc\""

This error is due to the current merging strategy of imported config sections. It definitely had some drawbacks, and specifically, a contributor has been working on an improved strategy in a PR I'll link below. In the current implementation, your second file with definitions for a new runtime entry is effectively replacing, not adding to, the definitions for runtimes in the main file. If you move everything about CRI to the second file (the whole subtree of the config) then the CRI plugin works properly.

More details in this PR: #9982

from containerd.

Hi @estesp ,
thank you for looking into this.
I can confirm that if I build my imported config like this it works:

[plugins."io.containerd.grpc.v1.cri".containerd]
default_runtime_name = "runc"
discard_unpacked_layers = true
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
runtime_type = "io.containerd.runc.v2"
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc.options]
SystemdCgroup = true
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.wasmedge]
runtime_type = "io.containerd.wasmedge.v1"
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.wasmedge.options]
BinaryName = "/bin/containerd-shim-wasmedge-v1"
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.spin]
runtime_type = "io.containerd.spin.v2"
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.spin.options]
BinaryName = "/bin/containerd-shim-spin-v2"

Containerd will restart with no errors and the CRI will be okay.
I must have overlooked the warning in the stdout/stderr of containerd initially. When I looked for it today, I found it of course.
I am curious to see how the PR works out in the end.

from containerd.