Comments (2)
slonopotamus
commented on May 27, 2024
And the reason for the crash is that ptsname in tc_darwin.go is totally broken.
First, it attempts to use %d to print a 64-bit value.
Second, and most important, it doesn't properly use syscall.TIOCPTYGNAME. It is supposed to be called something like this:
func ptsname(f *os.File) (string, error) {
n := make([]byte, 128)
if _, _, errno := syscall.Syscall(syscall.SYS_IOCTL, f.Fd(), syscall.TIOCPTYGNAME, uintptr(unsafe.Pointer(&n[0]))); errno != 0 {
return "", errno
}
end := bytes.IndexByte(n, 0)
if end < 0 {
return "", errors.New("TIOCPTYGNAME string not NUL-terminated")
}
return string(n[:end]), nil
}from console.
terrywh
commented on May 27, 2024
@dmcgowan can we merge this?
from console.
Related Issues (14)
- Switch license to ALv2
- Copyright is missing
- Maybe more example ,please? HOT 2
- Create a release tag for console project HOT 2
- hitting weird error on go get HOT 10
- Cut a release HOT 4
- windows: Why `initStdios` ignores `GetConsoleMode` errors? HOT 1
- ec.Console.Read() return -1 on EAGAIN HOT 1
- inappropriate ioctl for device
- Restore Solaris and Illumos support? HOT 6
- New release request HOT 2
- SetRaw hangs when using exec.Command in linux
- Windows: stderr output leaks into stdout HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from console.