Giter Club home page Giter Club logo

Comments (3)

andreivasiliu avatar andreivasiliu commented on August 15, 2024

+@cthachuk who authored the original commit

from indicatif.

cthachuk avatar cthachuk commented on August 15, 2024

@andreivasiliu yes, these use cases were overlooked when draw delta was implemented. That feature should be opt-in, so this is a bug in those case. I think your immediate fix works. I couldn't think of an easy way to opt-in only for .inc() calls, but that would be great if you think of a solution / work on a PR.

from indicatif.

andreivasiliu avatar andreivasiliu commented on August 15, 2024

I was thinking of this:

  • if new_pos <= old_pos: always draw
    • In other words, it was either .inc(0) or some other non-inc() operation
  • if new_pos > old_pos: draw based on draw_delta
    • In other words, it was one of .inc(x) if x > 0 or .set_pos()

But then I realized that although your fastbar example only calls .inc(1) in that gigantic for loop, people might want to set a custom message for every iteration as well, and they won't have any way to take advantage of this optimization.

I'll just make the default delta be 0, and add documentation that mentions everything else will be suppressed until enough .inc() calls are made if draw_delta >= 1.

from indicatif.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.