Giter Club home page Giter Club logo

Comments (3)

VasekPurchart avatar VasekPurchart commented on September 19, 2024

Is this the whole class? As in there is no namespace? (I see no PHP open tag and Exception is not used while Throwable is, so it seems pretty suspicious to me).

from coding-standard.

lookyman avatar lookyman commented on September 19, 2024

Nope, of course it's not a whole class 😊 It's just an excerpt to show the issue. The problem seems to be here.

from coding-standard.

miroslavhajek avatar miroslavhajek commented on September 19, 2024

This problem is not fixed in https://github.com/consistence-community/coding-standard/pull/3/files - condition accepts only FCQN.

Use

if (
    !in_array($lastArgument->getTypeHint(), ['\Throwable', '?\Throwable', 'Throwable', '?Throwable'], true)
    && !StringHelper::endsWith($lastArgument->getTypeHint(), 'Exception')
    && !StringHelper::endsWith($lastArgument->getTypeHint(), 'Error')
)

instead of line 119 where was added: $lastArgument->getTypeHint() !== '?\Throwable'

from coding-standard.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.