Comments (3)
Is this the whole class? As in there is no namespace? (I see no PHP open tag and Exception
is not used while Throwable
is, so it seems pretty suspicious to me).
from coding-standard.
Nope, of course it's not a whole class 😊 It's just an excerpt to show the issue. The problem seems to be here.
from coding-standard.
This problem is not fixed in https://github.com/consistence-community/coding-standard/pull/3/files - condition accepts only FCQN.
Use
if (
!in_array($lastArgument->getTypeHint(), ['\Throwable', '?\Throwable', 'Throwable', '?Throwable'], true)
&& !StringHelper::endsWith($lastArgument->getTypeHint(), 'Exception')
&& !StringHelper::endsWith($lastArgument->getTypeHint(), 'Error')
)
instead of line 119 where was added: $lastArgument->getTypeHint() !== '?\Throwable'
from coding-standard.
Related Issues (13)
- SlevomatCodingStandard.Exceptions.DeadCatch hangs for weird catch definition HOT 1
- Consider dropping HHVM support/build HOT 1
- Update to phpcs 3.3.0 HOT 5
- SlevomatCodingStandard.ControlStructures.YodaComparison is removed HOT 4
- Coding standard does not specify negation formatting HOT 3
- Support for PHPCS 2.6 HOT 1
- Support slevomat/coding-standard ^6.0 HOT 1
- Closure variables from use are handled same way as its parameters
- Support slevomat/coding-standard 6.1.* HOT 2
- PHP 8 Support HOT 1
- FunctionSpacing sniff misconfigured HOT 4
- Rules for PHP 7 features HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coding-standard.