Implement native OS X window handling for close/quit about photon HOT 14 OPEN

Sounds like a nice UX addition.

from photon.

Sounds quite nice. Afterall the project seems very OS X oriented.

from photon.

👍

from photon.

👍

from photon.

Submitted PR #29 to implement native OS X window handling.

from photon.

Isn't this behavior already there? All the keyboard commands you listed already work for me when I launch the template app.

from photon.

Not in Electron core. There are a few issues in the GH issues for it, but not out of the box.

from photon.

@ggamel I'm curious, which version of OS X are you running?

from photon.

@connors: OS X 10.11. No betas.

from photon.

@connors Also see: sindresorhus/caprine#6

This is something that others have been wanting, but is apparently not included in Electron by default. My implementation has been working as expected. 😄

from photon.

@ggamel Weird. I'm confused because when I run npm start, I can do all the behaviors you've listed.

This line in app.js makes sure that the default OS X behavior is respected.

from photon.

@connors Crazy! I'll try again with a fresh copy of photon to see if it's in-line with your experience. Otherwise, I'll make a screencast to show you!

from photon.

Okay, @connors: I received the exact same window behavior from a vanilla clone.

See:

Any ideas on what the issue could be?

from photon.

@connors I just realized I never listed clicking the dock icon and showing the app window in my original issue comment. Just updated that comment to clarify!

Are you able to click the dock icon to activate the Photon app window?

My code/commit introduces:

• the ability for the active Photon window to persist in the background, even after pressing Cmd+W or the red X stoplight, meaning if audio is playing in the Photon window, for instance, it will continue uninterupted
• the ability to activate again by clicking the app icon.

Essentially, the default behavior in Electron (this line), after pressing Cmd+W or the X stoplight destroys the BrowserWindow, meaning you either have to recreate it (acceptable in some situations) or have some code that keeps it alive/hidden. My code ensures the BrowserWindow hasn't been destroyed and instead persists until you force quit or Cmd+Q. 😀

from photon.