Comments (10)
just assigned! thanks for the help. Would it be possible to push before Tuesday or Wednesday? (I'm publicizing the showcase then), if not I can take a look at it and try to fix it
from p5.js-showcase.
Yes, I'll push it before Tuesday. Thanks!
from p5.js-showcase.
Awesome! Thanks for the help :)
from p5.js-showcase.
@connieliu0 Hey, I am almost done with the solution. Just one thing is left!
Can you tell me which component is this? I'm not able to find it.
Thanks.
from p5.js-showcase.
@chtushar it would be great if the language bar could be underneath the nav bar! on the full size it is to the left though. Also, the component that holds the stars has the id "P5Wrapper" and the code that links the sketch to the main page is ! I don't know why there is a giant margin to the left of the sketch though, it doesn't show up there on my screen.
from p5.js-showcase.
@connieliu0 Okay got it!
from p5.js-showcase.
-
This part is little messed up soI've added
overflow-x: hidden
in CSS so it removes horizontal scrollbar completely.
One little suggestion, mobile phones anyway don't have space bar so we can hide "P5Wrapper" for mobile.
from p5.js-showcase.
Should I make a pull request?
from p5.js-showcase.
https://p5-js-showcase.vercel.app/ this one is with changes that I've made. :)
from p5.js-showcase.
@chtushar a pull request would be great! I think I'll keep the viz up anyways (space bar just changes the colors/text), that way they know they can access the website on desktop for a fuller view! Let me know as soon as you finish the pull request and I can merge!
from p5.js-showcase.
Related Issues (12)
- Unexpected behaviour of scrollbars HOT 1
- Spanish translation plurals and generics are wrong HOT 3
- Adding Hindi language translations HOT 11
- Heading on about page not visible completely on small screen sizes HOT 2
- Improving the project README HOT 3
- Project name headings have a poor contrast HOT 5
- Project Section: Project cards are not identical
- Fixing the layout of the cards in gallery HOT 1
- The navber css should be consistent. HOT 2
- [Map Interaction] Disable scroll zoom HOT 1
- [Acknowlegements] Add acknowledgements section HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from p5.js-showcase.