Giter Club home page Giter Club logo

Comments (5)

oriol avatar oriol commented on July 28, 2024 1

Sorry @juskoljo, yes please add another issue.

from einvoicing-en16931.

juskoljo avatar juskoljo commented on July 28, 2024

Hi,

Thanks for the fix!

I'm wondering why rule context has cac:RegistrationAddress and cac:DeliveryAddress as those are not part of EN16931 model? (https://test-docs.peppol.eu/poacc/billing/3.0/rules/ubl-tc434/)

<rule context="//cac:PostalAddress | //cac:RegistrationAddress | cac:DeliveryAddress">
  <assert id="UBL-SR-51" flag="fatal" test="not(cac:AddressLine) or count(cac:AddressLine) = 1">...</assert>
</rule>

Also it seems that DeliveryLocation is not covered with the updated rule.

<cac:Delivery>
  <cbc:ActualDeliveryDate>2014-01-01</cbc:ActualDeliveryDate>
  <cac:DeliveryLocation>
    <cbc:ID schemeID="0088">1238764941386</cbc:ID>
    <cac:Address>
      <cbc:StreetName>StreetName</cbc:StreetName>
      <cbc:CityName>CityName</cbc:CityName>
      <cbc:PostalZone>1234</cbc:PostalZone>
      <cac:AddressLine>
        <cbc:Line>AddressLine/Line</cbc:Line>
      </cac:AddressLine>
      <cac:AddressLine>
        <cbc:Line>AddressLine/Line</cbc:Line>
      </cac:AddressLine>
      <cac:AddressLine>
        <cbc:Line>AddressLine/Line</cbc:Line>
      </cac:AddressLine>
      <cac:AddressLine>
        <cbc:Line>AddressLine/Line</cbc:Line>
      </cac:AddressLine>
      <cac:Country>
        <cbc:IdentificationCode listID="ISO3166-1:Alpha2">NO</cbc:IdentificationCode>
      </cac:Country>
    </cac:Address>
  </cac:DeliveryLocation>
</cac:Delivery>

With Best Regards,
Jussi

from einvoicing-en16931.

juskoljo avatar juskoljo commented on July 28, 2024

Should I create a new issue about this? @oriol @phax

from einvoicing-en16931.

juskoljo avatar juskoljo commented on July 28, 2024

Thanks @oriol, new issue is now submitted!

from einvoicing-en16931.

petredanoiu avatar petredanoiu commented on July 28, 2024

hi,
so the rule UBL-SR-51 has been changed?
the current version v.1.3.10 incorrectly applies it, in my opinion.
in UBL-Invoice-2.1xsd: cac:AddressLine element is (0..n) with cbc:Line (1..1)

so the above xml example is correct, but not valid because of UBL-SR-51.

Am i wrong?
10x

from einvoicing-en16931.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.