Giter Club home page Giter Club logo

Comments (7)

qshao-pivotal avatar qshao-pivotal commented on May 28, 2024 1

you were added in that slack channel

from cp-helm-charts.

pavel-agarkov avatar pavel-agarkov commented on May 28, 2024 1

Even if you are not going to include probes by default - they might be optional.
At least let's collect all the ideas and best practices somewhere so people can for example vote for them.
For KSQL I've tried this but nothing actually worked since rest api turned off when queries file specified and ksql-print-metrics script is present in cp-ksql-server image but looks like some .jars are missing...
For Connect I use the following probe:

livenessProbe:
  exec:
    command:
      - bash
      - -c
      - curl -v --silent http://localhost:8083/connectors/PUT_CONNECTOR_NAME_HERE/status 2>&1 | grep \"RUNNING.*RUNNING\" 1>/dev/null

from cp-helm-charts.

dkirrane avatar dkirrane commented on May 28, 2024 1

@qshao-pivotal Interested in this discussion too, can you add me to slack discussion?
How does cp-helm-chart handle graceful-shutdown (controlled.shutdown.enable=true). Are there plans to use probes?

from cp-helm-charts.

qshao-pivotal avatar qshao-pivotal commented on May 28, 2024

We have it before, but after discussion with Confluent Cloud Team and doing some performance test, We decided to remove it. We may add it back once we figure out more reasonable parameter values.

from cp-helm-charts.

framiere avatar framiere commented on May 28, 2024

can give me a pointer to the discussions ?

from cp-helm-charts.

qshao-pivotal avatar qshao-pivotal commented on May 28, 2024

Haven't head anything. closing it.

from cp-helm-charts.

galvo avatar galvo commented on May 28, 2024

Would like to get added to this slack channel also.. i think re-adding probes needs to be given some high priority, and willing to contribute to this effort, I would like to open a new issue to track this.

from cp-helm-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.