Giter Club home page Giter Club logo

Comments (14)

pelson avatar pelson commented on July 21, 2024

I completely see where you are coming from.

I'm thinking there is no reason, if the --no-inspect-conda-bld-directory flag isn't set, not to look in conda-build, if it's there, don't rebuild, but do upload.

The problem is that you are using a build tool to do uploads IMO. I wouldn't want to upload anything that hadn't just been built with conda-build-all. Perhaps we can use the same machinery and talk about a conda-upload-all?

from conda-build-all.

pelson avatar pelson commented on July 21, 2024

@mwcraig may want to have a heads up about this thread also. (re conda-forge/staged-recipes#593 (comment))

from conda-build-all.

jakirkham avatar jakirkham commented on July 21, 2024

So, the other option that came up and was discussed was @ericdill's script to do this.

from conda-build-all.

mwcraig avatar mwcraig commented on July 21, 2024

I agree with @ChrisBarker-NOAA that conda-build-all Ought to upload in this case; in principle it is no different than copying a build from one owner's channel to another (and the one or two line fix goes in the same branch in artefact_destination as the cross-owner copying. Noticed this last week and haven't gotten around to a pull request.

That doesn't remove the need for @ericdill's script, but that fulfills a different purpose, I think.

I understand conda-build-all to be the tool that says "figure out the full matrix of builds needed, then look in all of these places (inspect channels, local builds directory) for existing builds, otherwise actually do the build, and in any event upload built distribution to this (potentially other) channel."

from conda-build-all.

pelson avatar pelson commented on July 21, 2024

and in any event upload built distribution to this (potentially other) channel

That is the detail, right 😄. I can see the case for both behaviours.

from conda-build-all.

ChrisBarker-NOAA avatar ChrisBarker-NOAA commented on July 21, 2024

On Thu, Jun 30, 2016 at 8:08 AM, Phil Elson [email protected]
wrote:

and in any event upload built distribution to this (potentially other)
channel

That is the detail, right 😄. I can see the case for both behaviours.

I imagine we all see the case for both behaviours. In some sense, yes,
build-all and upload-all are different things, but:

  1. conda-build-all already does both

  2. it would be kin dof annoying to have to do the two steps separately --
    that's why is was designed the way it is in the first place.

I suggest another flag:

--upload-packages-in-conda-bld-directory

and we're done, yes?

implementation is a different issue, of course :-)

and how it interacts with --no-inspect-conda-bld-directory is a bit sketchy
-- I suggest:

if not inspecting conda-bld, then it wouldn't upload from conda-bld

if inspecting conda-build, then it would upload them if the
--upload-packages-in-conda-bld-directory flag was set.

-CHB

from conda-build-all.

mwcraig avatar mwcraig commented on July 21, 2024

Along the lines of what @ChrisBarker-NOAA just said, it does look like the ability to copy is built in to conda-build-all already and was designed for that possibility. Agreed that it then makes less sense as a plugin for conda build.

What about adding a flag --force or --force-build or --always-build that compels the build?

from conda-build-all.

pelson avatar pelson commented on July 21, 2024

I wouldn't be against a --skip-existing flag, which doesn't build if the package already exists locally.

from conda-build-all.

ChrisBarker-NOAA avatar ChrisBarker-NOAA commented on July 21, 2024

Sounds good.

If I put in the boilerplate infrastructure (arg parsing, etc), can one of you find the time to do the actual functionality? Or point me to where in the code to do it -- might be4 more efficient than me figuring out how to navigate the code.

from conda-build-all.

mwcraig avatar mwcraig commented on July 21, 2024

I'm also happy to implement at scipy....

from conda-build-all.

ChrisBarker-NOAA avatar ChrisBarker-NOAA commented on July 21, 2024

On Thu, Jul 7, 2016 at 10:05 AM, Matt Craig [email protected]
wrote:

I'm also happy to implement at scipy....

Good idea -- I'll be there. Phil, will you be there too?

-CHB

Christopher Barker, Ph.D.
Oceanographer

Emergency Response Division
NOAA/NOS/OR&R (206) 526-6959 voice
7600 Sand Point Way NE (206) 526-6329 fax
Seattle, WA 98115 (206) 526-6317 main reception

[email protected]

from conda-build-all.

mwcraig avatar mwcraig commented on July 21, 2024

I hope Phil will be there, he is talking on Friday :)

from conda-build-all.

pelson avatar pelson commented on July 21, 2024

BoF on Weds, sprint Saturday.
If either of you are sprinting and would be prepared to mentor/pair up with novices, there is a trello board where you could add this: https://trello.com/b/KURmGkly/conda-forge-scipy-sprint

from conda-build-all.

mwcraig avatar mwcraig commented on July 21, 2024

Will be at both, planning to spend my sprint time on conda/conda-forge. Couldn't figure out how to add anything to the trello board (am happy to mentor/pair).

from conda-build-all.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.