Giter Club home page Giter Club logo

Comments (16)

jakirkham avatar jakirkham commented on September 27, 2024 1

Well, I ran CI under my own user and that fixed almost all issues except for 64-bit support with VS 2008. In other words, we require this fix ( conda-forge/conda-smithy#107 ). Sorry, I misspoke. This does not seem to be true. The build merely hung mysteriously immediately after cloning.

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

That is a very special error. I'm not really sure how we got into this situation.

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

I dropped it in the "I need help on Windows" issue so hopefully someone with a dev environment who knows more can figure this out. Were there any recent releases of conda as this was working before? Appears not.

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

Oh, maybe we need python as a testing requirement. Thoughts? I'll draw up a PR. Feedback welcome. 😄

from hdf5-feedstock.

ocefpaf avatar ocefpaf commented on September 27, 2024

Oh, maybe we need python as a testing requirement. Thoughts? I'll draw up a PR. Feedback welcome. 😄

Makes sense... I guess...

If that works can you update the wiki?

https://github.com/conda-forge/staged-recipes/wiki/VC-features

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

Still weird that it worked before though. Maybe there is some subtle difference between CI here and in staged-recipes?

from hdf5-feedstock.

msarahan avatar msarahan commented on September 27, 2024

Python should not be required in tests if it is required in run requirements. However, there is one crazy issue: Test requirements are NOT pinned the same way that run requirements are: conda/conda-build#835

I can't explain the inconsistent behavior, but it might be related to that issue.

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

Slowly coming back to me. We ran into this issue with GLPK. Maybe I need to tweak the recipe here to match. That or will need @pelson's CI improvements. Might want to wait to see how GLPK gets fixed before implementing something here. @jjhelmus @pelson, do either of you have any thoughts on this point?

from hdf5-feedstock.

jjhelmus avatar jjhelmus commented on September 27, 2024

At least for GLPK adding python as a run requirement on Winodws fixed the build issue. I agree with the desire for a more elegant solution either with a msvc package or in conda build itself but until then the python run requirement will do the trick.

from hdf5-feedstock.

ocefpaf avatar ocefpaf commented on September 27, 2024

@jakirkham I guess the original issue here is resolved, correct? I saw the logs and there is a new problem:

C:\conda\conda-bld\test-tmp_dir>where h5c++ 
INFO: Could not find files for the given pattern(s).

C:\conda\conda-bld\test-tmp_dir>if errorlevel 1 exit 1 

I believe that has a simple solution (missing .exe extension).

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

So, I think the problem is that executable doesn't exist on Windows. Not sure why that is. However, if you look earlier in the log, you will see that never copied over into the binaries' directory.

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

Yeah, appears these are UNIX only. Will fix the test and then it should be ok.

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

Think we have incorporated these fixes. Will see if it builds correctly this time.

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

cc @pelson

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

I believe that I have fixed this problem. Here were the problems.

  1. VC features were not being followed on Windows during testing.
  2. UNIX only binaries were being searched for on Windows.
  3. It appears that h5perf_serial is missing on Windows.

The first two make sense and have been fixed. Though given the issues with 1, it is possible it will resurface and will keep an eye open for bug reports there to see if we need a better fix. As for 3, this doesn't seem like it should be a problem and it is being built as one can see in the AppVeyor log; however, the test for it fails. Given I don't really have a Windows dev environment, I appreciate any help I can get on that point. My current plan is to inspect the Windows binaries (once available) to see if this is getting renamed somehow. However, I didn't want to hold up binaries that otherwise seem to work over this one missing command line tool.

from hdf5-feedstock.

jakirkham avatar jakirkham commented on September 27, 2024

Looks like Windows builds are released. 🎉

from hdf5-feedstock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.