Having the linter comment on PRs about conda-smithy HOT 11 CLOSED

I see. So you put the job in the CI script, and it comments on its own PR based on linting information. I really like that! 👍

from conda-smithy.

Maybe this needs to be at staged-recipes? Not sure.

from conda-smithy.

Would be a great service. How is your heroku?

from conda-smithy.

I guess I am thinking of staged-recipes first. Just because that is where every one is trying new things out. Normally, once the recipe is added, I figure it doesn't decay into spaghetti code that quickly (I hope I'm not wrong 😉). Do you think it wouldn't be possible with the Travis CI matrix job that is doing the linting?

from conda-smithy.

Did you already do this?! I must say, I'm impressed at how quickly you got this up.

Would it be possible to get line comments on the diff up to say the latest commit that is on Travis CI? Having summary comments is still useful I think, but having context for individual changes is pretty nice.

from conda-smithy.

Something we might want to consider, which could be a bit tricky, is to stop commenting if the PR is still in working order.

from conda-smithy.

Did you already do this?!

I taught myself heroku last night - I must say, it was an awful lot of fun! 😄

Would it be possible to get line comments on the diff up to say the latest commit that is on Travis CI?

Would you mind elaborating? I'm not entirely following 😕

Something we might want to consider, which could be a bit tricky, is to stop commenting if the PR is still in working order.

Yes, agreed. It may be tricky. I was thinking of either updating the status (the things that show a tick when CI runs) of the PR if there are no problems. Might make the whole thing a little less intrusive (though it is quite fun that you get a comment back within 3 seconds of submitting a pr 😄).

I'll be pushing the heroku code to another conda-forge repo either today or tomorrow. It is very lightweight.

from conda-smithy.

I taught myself heroku last night - I must say, it was an awful lot of fun! 😄

Nice! It is pretty cool. Already it is quite helpful.

Would it be possible to get line comments on the diff up to say the latest commit that is on Travis CI?

Would you mind elaborating? I'm not entirely following 😕

Sure. Suppose I forgot the extra/recipe-maintainers section. The bot could make a comment on the last line of the PR diff noting that I need to add the maintainers. It could get a bit hairy I suppose. We could hash out the cases in a different issue if you would like.

Something we might want to consider, which could be a bit tricky, is to stop commenting if the PR is still in working order.

Yes, agreed. It may be tricky. I was thinking of either updating the status (the things that show a tick when CI runs) of the PR if there are no problems. Might make the whole thing a little less intrusive (though it is quite fun that you get a comment back within 3 seconds of submitting a pr 😄).

So, I thought about it and while not a totally bad idea I don't think it replaces the comments. What I really like about the comments is they summarize the problems in the recipe(s). Statuses are better for if it is ok or not.

I suppose if you could check if the status has not changed and if it was already passing that could be used to skip the comment. If that is what you're thinking...

I'll be pushing the heroku code to another conda-forge repo either today or tomorrow. It is very lightweight.

Cool, I'd be curious to see. So, does it just wait for PR change notifications from GitHub?

from conda-smithy.

Sure. Suppose I forgot the extra/recipe-maintainers section. The bot could make a comment on the last line of the PR diff noting that I need to add the maintainers. It could get a bit hairy I suppose. We could hash out the cases in a different issue if you would like.

Whoa! Wow - that's a cool idea! ❤️
Our linter doesn't yet report the line number, but when it does, that would be totally possible!

So, does it just wait for PR status updated?

Yes. It is hooked to pullrequestevent on v3 github api: https://developer.github.com/v3/activity/events/types/#pullrequestevent

from conda-smithy.

Closing as this is already implemented. The ideas that haven't been implemented are issues on the relevant repo at this point ( https://github.com/conda-forge/conda-forge-webservices ).

from conda-smithy.

had by this idea
{% set version = load_setup_py_data().version %}

conda-forge-linter telling:
Failed to even lint the recipe (might be a conda-smithy bug)

from conda-smithy.