Placehold.io does not work about comurimagebundle HOT 8 CLOSED

Good idea ! Can someone change it or i will do next week.

Thanks @Tersoal

from comurimagebundle.

Hi.

I have uploaded the change. In the doc, it must included the flag to use or not the holder, like this:

{% include "ComurImageBundle:Form:croppable_image_modal.html.twig" with {'include_jquery': false, 'include_bootstrap': false, 'include_holder': false} %}

from comurimagebundle.

Hi @Tersoal

can you send me a PR for this issue ?

thanks

from comurimagebundle.

https://placehold.io/589/300

For me it's working but your idea is better to not depend on outer systems so if you have any time to send me a PR i can merge it, thanks.

i was using placehold.it but it does not support https...

from comurimagebundle.

Sorry, I'm not skilled with github and forks. Can't you see the last commit?

from comurimagebundle.

hye can you push url replacement on v1.0 branche please

from comurimagebundle.

I did it in a better (i think) way by including holderjs in composer. I have to test it

from comurimagebundle.

Well it's not working for now, i have to find a solution to publish holder.js in assets but without copying it in the bundle. If we copy, we cannot update holderjs.

So i will use a cdn for now, if someone has a solution for this i will appreciate :)

from comurimagebundle.