Giter Club home page Giter Club logo

Comments (6)

SmartLayer avatar SmartLayer commented on August 19, 2024

Observe the price in this picture is the same as previously demonstrated but the amount of ETH to be received is less than 1Ξ, suggesting that this is the correct behaviour:

signal-2020-10-13-164520_001

Therefore, if the user types 1Ξ as the amount of ETH to receive, the correct number in PICTURE 1 should be
383.48843610/0.99103639=386.95696

from cofix-web-user-interface-v2.0.

zhangzhongnan928 avatar zhangzhongnan928 commented on August 19, 2024

This function has been removed. As on the contract level we cannot set a To amount for erc20-erc20 swap.

But I agree, the calculation is wrong.

from cofix-web-user-interface-v2.0.

zhangzhongnan928 avatar zhangzhongnan928 commented on August 19, 2024

We do support ERC20 - ERC20 Swap. but we don't support, setting a fixed To amount for erc20-erc20 swap.

Setting a fixed TO amount in ETH-ERC20 is supported.

from cofix-web-user-interface-v2.0.

SmartLayer avatar SmartLayer commented on August 19, 2024

We do support ERC20 - ERC20 Swap. but we don't support, setting a fixed To amount for erc20-erc20 swap.

Setting a fixed TO amount in ETH-ERC20 is supported.

@hellolucas @colourfreak in this case how should we design the interaction?

from cofix-web-user-interface-v2.0.

hellolucas avatar hellolucas commented on August 19, 2024

To be clear, the issue is that the user cannot set a number in the "TO" field, only in the "FROM", thats correct? At least its how its working right now. I'd suggest a simple highlight difference, with maybe blinking writing prompter. Like so:

Swap_Desktop_In_Empty

from cofix-web-user-interface-v2.0.

foxgem avatar foxgem commented on August 19, 2024

this issue should be fixed in v1.1.0 (also in v1.0) since after checking calculation several times with more eyes, ;).

Here is current result:

  • 1 eth -> 384.5237613 usdt
  • 384.5237613 usdt -> 0.99103639 eth.

from cofix-web-user-interface-v2.0.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.