Comments (6)
jenschude
commented on June 3, 2024
1
It's a nice catch. I opened a PR in the upstream repository, so that the type can be fixed. As the query body is not yet completely modelled the query field will be an empty interface which means that for a query a class has to be defined.
I'm still not pleased with this. So could be that we have to change this in the future.
Please see 52cae06
Before releasing a patch version it would be nice to get your feedback
from commercetools-dotnet-core-sdk-v2.
andrewchaa
commented on June 3, 2024
I agree that the fix on the upstream is more elegant.
from commercetools-dotnet-core-sdk-v2.
jenschude
commented on June 3, 2024
Fixed with 2.5.1
from commercetools-dotnet-core-sdk-v2.
senj
commented on June 3, 2024
Hi @jenschude , I think the same is still true for the Sort property, also string but array is expected.
from commercetools-dotnet-core-sdk-v2.
jenschude
commented on June 3, 2024
Thanks for the report! Will tackle it
from commercetools-dotnet-core-sdk-v2.
jenschude
commented on June 3, 2024
Released 5.2.0 with the fix
Thanks for reporting @senj
from commercetools-dotnet-core-sdk-v2.
Related Issues (20)
- CentPrecisionMoney conversion mismatch HOT 1
- Quotes: quoteState missing from IQuote in commercetools.Sdk.Api.Models.Quotes HOT 3
- MessageSubscription: Breaking change from 5.1 to 5.2? HOT 1
- Question about Serialization/Deserialization of messages HOT 8
- Custom timeouts and retries on HTTP Client HOT 2
- Issue Creating Cart with Custom Line Item with Line-Item Custom Field HOT 1
- No Blazor WASM support HOT 4
- Product exists HEAD call support HOT 1
- Image upload always missing content type HOT 1
- OOTB models in SDK not serializing properly HOT 9
- How to create a HTTP Subscription with Extension Destination HOT 1
- Use ISerializerService in Dependency Injection Setup HOT 5
- Commercetool HTTP Client not working with Single-file deployment
- Fix Security Vulnerability with System.Text.Encodings.Web HOT 2
- Bypass 409 concurrentmodificationexception and overwrite the resource HOT 1
- LineItems is null but it should not be null. Schema can be outdated HOT 2
- Unable to Add header with IClient HOT 6
- ProductProjectionPagedQueryResponse is Generated with a long Offset while the query only accepts a int32 offset. HOT 2
- Filter categories by subtree HOT 1
- BadRequest On FailedLogin (Wrong username/password) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commercetools-dotnet-core-sdk-v2.