Comments (11)
Hey @d2iqpchavan,
Thank you for the issue. Just to be clear I'm understanding you, you're running command from a local shell. You're not operating in a container or anything right?
Also do you mind sharing a sample of your manifest if you can?
Thanks!
from commander.
Yes, I am running command from my local shell, (apple m1 darwin arm64 to be specific).
Sorry but I do not know what do you mean by manifest? Is this pre req to test via commander? Can you elaborate please?
from commander.
I apologize for not being clear.
What I meant to refer to is your test suite. Your commander.yaml
file or similar file of a different name. Iād like to see your test job so I can replicate it. Your test suite should look something like.
tests:
it should print hello world:
command: docker ps -a --filter label=io.x-k8s.kind.cluster --format '{{.Label "io.x-k8s.kind.cluster"}}'"
stdout: hello world
exit-code: 0
from commander.
the issue is the docker command is not independent, our internal tool command spins up docker as second step in the process
here is my test suite
tests:
konvoy create:
command: ./konvoy create <name> --kind-cluster-image kindest/node:v1.21.2
exit-code: 0
stdout:
contains:
- Creating bootstrap
from commander.
I believe I understand now.
So ./konvoy is some type of internal tooling (binary, executable) that is making some form of exec() call to the system that has docker installed on it. I assume this where we are losing the context of the $PATH variable.
I do not know enough about this executable to give a precise answer. I have hunch that it could be related to how docker
is being executed. Something like this could help.
I'll work up a quick test to confirm that commander
operates as we expect based upon my current "hunch" and provide the results. Any additional context you could provide would be helpful.
from commander.
you are absolutely right. I tested docker and konvoy both on shell on the current path hence I think your hunch is right.
Let me try this meanwhile. THANK YOU! please let me know what do you find
from commander.
@dylanhitt do you want to brainstorm on this? or any suggestions on how do I proceed?
from commander.
@d2iqpchavan did you give what i described a shot? I won't get around to replicating what I believe is happening until next week.
from commander.
no worries - I am not familiar with source code of the konvoy project as much so so far I have not figured on updating the exec command to add ssh or bash- I was trying to leverage this plugin on the top of konvoy.
from commander.
I had a similar issue with a different executable, and getent not being found in the path when running via commander.
After some playing around with the application, it was a dependency of the executable that was using getent, and then causing the problem. The executable was fine when ran via bash or zsh (both of which found getent via which getent
), but failing when ran via commander.
I fixed the issue by removing the dependency from the application.
from commander.
thanks for all your help. I am unblocked and the issue was with my local path and I added that as part of env
in config
config:
env:
PATH: ${PATH}
from commander.
Related Issues (20)
- "Test may not be filtered when --dir is enabled" HOT 5
- Test Suite aggregation should occur in runtime HOT 2
- Create a custom GitHub action for Commander HOT 1
- Properly mock file and dirs in app tests to not read from the filesystem
- config value dir, should work for file assertion
- user should be able to set the working dir with `--workdir` HOT 1
- Add junit ouput support HOT 1
- Move away from travisCI HOT 5
- Add yaml linter in CI
- documented install command fails with go 1.16 HOT 5
- Upgrade docker version
- Change []runtime.TestCase in Suite to an array of pointers
- SSH public key authentication broken in commander 2.4.0 on CentOS 8.4.2105 HOT 1
- Enable regular expression for stdout, stderr assertion HOT 3
- Add proper error handling and coroutine cancellation
- Rename TestCommandContext to TestCommandConfig
- Support bash and awk verifiers HOT 1
- Commands in Installation section try to download non-existing version HOT 1
- dotfiles in test dir cause a panic HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commander.