Spandrel addition brakes restoration nodes using GFPGAN models about comfyui HOT 12 CLOSED

Any idea when this is going to be fixed? <3 my workflow stopped working :(

You can temporarily roll back to the commit ffc4b7c

  git checkout ffc4b7c

when you want to return back - just switch the branch to master

  git checkout master

from comfyui.

Any idea when this is going to be fixed? <3 my workflow stopped working :(

from comfyui.

So it broke after a commit that deleted all of the code? 17,700+ deletions... I wonder why it's not working right. Just kidding.

It was a very large change, that replaced comfy functions with spandrel, and Im going to assume the issue is probably with spandrel, the code in the commit looks okay to me, at cursory glance without tracing the execution.

The actual code changes besides using spandrel are quite minor (considering 17k lines were deleted), and load from state dict is pretty universal, so I'd say it's probably a bug in spandrel related to that particular model.

This is the only real change.

 out = model_loading.load_state_dict(sd).eval()

to the spandrel version

 out = ModelLoader().load_from_state_dict(sd).eval()

outside of that the only change is

upscale_model.to("cpu")

which updates

upscale_model.cpu()

to use the currently preferented syntax with pytorch. x.cpu and x.cuda are deprecated in favor of x.to(device)

from comfyui.

same problem,

from comfyui.

Any idea when this is going to be fixed? <3 my workflow stopped working :(

You can temporarily roll back to the commit ffc4b7c

  git checkout ffc4b7c

when you want to return back - just switch the branch to master

  git checkout master

It worked for me! Thanks!

from comfyui.

It's not a problem with spandrel.

Previous code required images normalized to -1 +1 range. Spandrel models universally require 0..1 range.
Reactor needs to be updated.

from comfyui.

Hello!
How difficult is it to fix this in new releases? It's been so long, some of my processes use updates, but for GFPGAN to work I have to use the old release.
Maybe there is already some updated custom Reactor node?
Maybe it is possible to insert conditions where ComfyUI could work correctly with GFPGAN in both new and old releases?

from comfyui.

I hope this gets patched soon ! 💕

I hope there is an open issue with spandrel

from comfyui.

thanks for posting this, I will wait for the update!

from comfyui.

知道什麼時候會修復這個問題嗎？ <3我的工作流程停止工作:(

可以暫時回滾到提交ffc4b7c

  git checkout ffc4b7c

當你想返回時 - 只需將分支切換到 master

  git checkout master

這對我有用！謝謝！

This is an english language repo, please keep comments in english so that other people may benefit from them.

from comfyui.

知道什麼時候會修復這個問題嗎？ <3我的工作流程停止工作:(

可以暫時回滾到提交ffc4b7c

  git checkout ffc4b7c

當你想返回時 - 只需將分支切換到 master

  git checkout master

thx working

from comfyui.

Fixed Gourieff/comfyui-reactor-node@a7ae669
Closing the Issue

from comfyui.